Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 376306

Summary: Can't install ECF because signature fails...
Product: [RT] ECF Reporter: John Smith <jsmith10001>
Component: ecf.coreAssignee: ecf.core-inbox <ecf.core-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3 CC: david_williams, denis.roy, jsmith10001, markus.duft, slewis, webmaster, wim.jongman
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on: 361628    
Bug Blocks:    
Attachments:
Description Flags
java8+lunasr1+ecf rs sdk 3.9.1 configuration
none
the list of mirrored (or downloaded) update sites that is included in the p2 composite site
none
the .target file we use (for real this time) none

Description John Smith CLA 2012-04-08 23:14:39 EDT
Build Identifier: I20120314-1800

For the past 2 days I have been trying to install ECF 3.5.5 and I keep getting the following error when i try to install:

An error occurred while collecting items to be installed
session context was:(profile=SDKProfile, phase=org.eclipse.equinox.internal.p2.engine.phases.Collect, operand=, action=).
Problems downloading artifact: osgi.bundle,org.jivesoftware.smack.source,3.1.100.v20120319-0616.
File has invalid content:C:\Users\x\AppData\Local\Temp\signatureFile7508490107388515338.jar
Invalid content:jars/xpp.jar
The file "jars/xpp.jar" in the jar "C:\Users\x\AppData\Local\Temp\signatureFile7508490107388515338.jar" has been tampered!


I tried doing the local install as well as the online install, they both give the same error. Why is this happening? This is my first time dealing with ECF so it may be user error, but I'm going through the same process that I would to install any other plugin and I made sure I followed the directions.

Reproducible: Always

Steps to Reproduce:
1. In Eclipse: Help >> Install new software
2. Enter in the install plugin directory or URL
3. Install only the Eclipse Communication Framework
4. Installation fails.
Comment 1 John Smith CLA 2012-04-08 23:15:31 EDT
I forgot to also note that I have tried to install it both on eclipse 3.7.2 as well as 3.8 beta, both are giving me the same exact error.
Comment 2 Wim Jongman CLA 2012-04-09 03:25:55 EDT
This behavior is confirmed. Is this something that should worry us? Adding webmaster just to be sure.
Comment 3 Wim Jongman CLA 2012-04-09 10:22:01 EDT
It is a nested jar jars/xpp.jar that get complaints.

File has invalid
content:C:\Users\x\AppData\Local\Temp\signatureFile7508490107388515338.jar
Invalid content:jars/xpp.jar

I tried installing with -Declipse.p2.mirrors=false but that resulted in the same message. Even when pointing to halifax.

These are the timestamps from the eclipse.org download server. All seems to be fine.

<snip>
12563 2012-03-19 02:57 org.eclipse.team.ecf.core_1.0.0.v20120319-0616.jar.pack.gz
23944 2012-03-19 02:57 org.eclipse.team.ecf.core.source_1.0.0.v20120319-0616.jar
17235 2012-03-19 02:57 org.eclipse.team.ecf.ui_1.0.0.v20120319-0616.jar.pack.gz
25558 2012-03-19 02:57 org.eclipse.team.ecf.ui.source_1.0.0.v20120319-0616.jar
75913 2012-03-19 02:57 org.jdom_1.1.1.v201101151400.jar.pack.gz
248173 2012-03-19 02:57 org.jivesoftware.smack_3.1.100.v20120319-0616.jar.pack.gz
608118 2012-03-19 02:57 org.jivesoftware.smack.source_3.1.100.v20120319-0616.jar.pack.gz
29665 2012-03-19 02:57 org.json_1.0.0.v201011060100.jar.pack.gz
77176 2012-03-19 02:57 org.objectweb.asm_3.3.1.v201105211655.jar.pack.gz
96835 2012-03-19 02:57 org.xbill.dns_2.0.8.v201010140805.jar.pack.gz
</snip
Comment 4 Scott Lewis CLA 2012-04-09 13:25:46 EDT
Strangely, I can't reproduce this with install of ECF 3.5.5 from our own repo:

http://download.eclipse.org/rt/ecf/3.5.5/site.p2

into Eclipse 3.8M6.

I'm not sure what is going on.  Webmaster...any thoughts?

On other equinox bugs, I've noticed some problem with pack/unpack in Java 1.7.  Is it possible that either of you (John or Wim) are using 1.7 as the jdk/jre?

One possible workaround (while we get this sorted out)...have you tried to install without the source (and therefore skip the smack source?).  You can always git the source here, of course:

http://git.eclipse.org/c/ecf/org.eclipse.ecf.git/
Comment 5 Wim Jongman CLA 2012-04-09 14:54:41 EDT
Yes our own repo gives me troubles as well and I have java 7.


> always git the source here, of course:

hehe
Comment 6 Scott Lewis CLA 2012-04-09 15:06:32 EDT
(In reply to comment #5)
> Yes our own repo gives me troubles as well and I have java 7.

It seems possible that this is an instance/duplicate of bug 361628

If John confirms that he is using java 7, then I think the only thing we can reasonably do is

1) Suggest that the source not be installed via p2
2) Suggest that java 6 be used 
3) Wait for fixes described in 361628

But John...if you would, please let us know...on comment on this bug...whether you are also using java 7.
Comment 7 John Smith CLA 2012-04-09 15:17:37 EDT
Yes I am using java 7 update 3, I'll try installing java 6 and report back...
here's a screenshot from my control panel for proof: http://i.imgur.com/ING1J.png

thanks for your help
Comment 8 Scott Lewis CLA 2012-05-03 16:06:10 EDT
See comment 27 in bug 361628:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=361628#c27

This provides us with a workaround for this pack issue on java 7 (we can avoid having xpp.jar...an inner jar...be packed).

I've tried this, and it appears to work...i.e. the xpp.jar is not packed.  

I would appreciate some others with java 7 already installed to try to install this version of ECF to verify that this bug is fixed.  The p2 repo for this is here:

http://download.eclipse.org/rt/ecf/3.5Test/site.p2

Thanks.  I'll resolve this bug, and if there is still a problem with java 7, please reopen.
Comment 9 Wim Jongman CLA 2012-05-03 16:59:06 EDT
Still the same problem:

An error occurred while collecting items to be installed
session context was:(profile=epp.package.jee, phase=org.eclipse.equinox.internal.p2.engine.phases.Collect, operand=, action=).
Problems downloading artifact: osgi.bundle,org.jivesoftware.smack.source,3.1.100.v20120503-1928.
File has invalid content:C:\Users\jongw\AppData\Local\Temp\signatureFile765363642554627052.jar
Invalid content:jars/xpp.jar
The file "jars/xpp.jar" in the jar "C:\Users\jongw\AppData\Local\Temp\signatureFile765363642554627052.jar" has been tampered!

==============================================
applicationXMI=org.eclipse.ui.workbench/LegacyIDE.e4xmi
awt.toolkit=sun.awt.windows.WToolkit
eclipse.application=org.eclipse.ui.ide.workbench
eclipse.buildId=I20120315-1300
eclipse.commands=-os
win32
-ws
win32
-arch
x86_64
-showsplash
C:\Users\jongw\My Programs\eclipse3.8M6\eclipse\\plugins\org.eclipse.platform_4.2.0.v20120315-1300\splash.bmp
-launcher
C:\Users\jongw\My Programs\eclipse3.8M6\eclipse\eclipse.exe
-name
Eclipse
--launcher.library
C:\Users\jongw\My Programs\eclipse3.8M6\eclipse\\plugins/org.eclipse.equinox.launcher.win32.win32.x86_64_1.1.200.v20110908-1331\eclipse_1500.dll
-startup
C:\Users\jongw\My Programs\eclipse3.8M6\eclipse\\plugins/org.eclipse.equinox.launcher_1.3.0.v20120308-1358.jar
--launcher.overrideVmargs
-exitdata
1c8c_5c
-product
org.eclipse.epp.package.jee.product
-vm
C:\Windows\system32\javaw.exe
eclipse.home.location=file:/C:/Users/jongw/My Programs/eclipse3.8M6/eclipse/
eclipse.launcher=C:\Users\jongw\My Programs\eclipse3.8M6\eclipse\eclipse.exe
eclipse.launcher.name=Eclipse
eclipse.p2.data.area=@config.dir/../p2
eclipse.p2.profile=epp.package.jee
eclipse.product=org.eclipse.epp.package.jee.product
eclipse.startTime=1336078369485
eclipse.vm=C:\Windows\system32\javaw.exe
eclipse.vmargs=-Dosgi.requiredJavaVersion=1.5
-Xms40m
-Xmx512m
-XX:MaxPermSize=256m
-jar
C:\Users\jongw\My Programs\eclipse3.8M6\eclipse\\plugins/org.eclipse.equinox.launcher_1.3.0.v20120308-1358.jar
equinox.use.ds=true
file.encoding=Cp1252
file.encoding.pkg=sun.io
file.separator=\
gosh.args=--nointeractive
java.awt.graphicsenv=sun.awt.Win32GraphicsEnvironment
java.awt.printerjob=sun.awt.windows.WPrinterJob
java.class.path=C:\Users\jongw\My Programs\eclipse3.8M6\eclipse\\plugins/org.eclipse.equinox.launcher_1.3.0.v20120308-1358.jar
java.class.version=51.0
java.endorsed.dirs=C:\Program Files\Java\jre7\lib\endorsed
java.ext.dirs=C:\Program Files\Java\jre7\lib\ext;C:\Windows\Sun\Java\lib\ext
java.home=C:\Program Files\Java\jre7
java.io.tmpdir=C:\Users\jongw\AppData\Local\Temp\
java.library.path=C:\Windows\system32;C:\Windows\Sun\Java\bin;C:\Windows\system32;C:\Windows;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Program Files (x86)\IBM\Client Access\Emulator;C:\Program Files (x86)\IBM\Client Access\Shared;C:\Program Files (x86)\IBM\Client Access\;C:\Program Files\SlikSvn\bin;C:\Users\jongw\My Programs\Maven\apache-maven-3.0.3\bin;C:\Program Files (x86)\Git\cmd;C:\Program Files\TortoiseSVN\bin;C:\PROGRA~2\Sybase\ASA9\SQL Anywhere 9\win32;C:\PROGRA~2\Sybase\ASA9\shared\win32;C:\PROGRA~2\Sybase\ASA9\shared\sybase central 4.3\java;C:\Users\jongw\IBM\SDP\bin;.
java.runtime.name=Java(TM) SE Runtime Environment
java.runtime.version=1.7.0_02-b13
java.specification.name=Java Platform API Specification
java.specification.vendor=Oracle Corporation
java.specification.version=1.7
java.vendor=Oracle Corporation
java.vendor.url=http://java.oracle.com/
java.vendor.url.bug=http://bugreport.sun.com/bugreport/
java.version=1.7.0_02
java.vm.info=mixed mode
java.vm.name=Java HotSpot(TM) 64-Bit Server VM
java.vm.specification.name=Java Virtual Machine Specification
java.vm.specification.vendor=Oracle Corporation
java.vm.specification.version=1.7
java.vm.vendor=Oracle Corporation
java.vm.version=22.0-b10
line.separator=

org.apache.commons.logging.Log=org.apache.commons.logging.impl.NoOpLog
org.eclipse.equinox.launcher.splash.location=C:\Users\jongw\My Programs\eclipse3.8M6\eclipse\\plugins\org.eclipse.platform_4.2.0.v20120315-1300\splash.bmp
org.eclipse.equinox.simpleconfigurator.configUrl=file:org.eclipse.equinox.simpleconfigurator/bundles.info
org.eclipse.update.reconcile=false
org.osgi.framework.executionenvironment=OSGi/Minimum-1.0,OSGi/Minimum-1.1,OSGi/Minimum-1.2,JRE-1.1,J2SE-1.2,J2SE-1.3,J2SE-1.4,J2SE-1.5,JavaSE-1.6,JavaSE-1.7
org.osgi.framework.language=en
org.osgi.framework.os.name=Windows7
org.osgi.framework.os.version=6.1.0
org.osgi.framework.processor=x86-64
org.osgi.framework.system.capabilities=osgi.ee; osgi.ee="OSGi/Minimum"; version:List<Version>="1.0, 1.1, 1.2",osgi.ee; osgi.ee="JRE"; version:List<Version>="1.0, 1.1",osgi.ee; osgi.ee="JavaSE"; version:List<Version>="1.0, 1.1, 1.2, 1.3, 1.4, 1.5, 1.6, 1.7"
org.osgi.framework.system.packages=javax.accessibility,javax.activation,javax.activity,javax.annotation,javax.annotation.processing,javax.crypto,javax.crypto.interfaces,javax.crypto.spec,javax.imageio,javax.imageio.event,javax.imageio.metadata,javax.imageio.plugins.bmp,javax.imageio.plugins.jpeg,javax.imageio.spi,javax.imageio.stream,javax.jws,javax.jws.soap,javax.lang.model,javax.lang.model.element,javax.lang.model.type,javax.lang.model.util,javax.management,javax.management.event,javax.management.loading,javax.management.modelmbean,javax.management.monitor,javax.management.namespace,javax.management.openmbean,javax.management.relation,javax.management.remote,javax.management.remote.rmi,javax.management.timer,javax.naming,javax.naming.directory,javax.naming.event,javax.naming.ldap,javax.naming.spi,javax.net,javax.net.ssl,javax.print,javax.print.attribute,javax.print.attribute.standard,javax.print.event,javax.rmi,javax.rmi.CORBA,javax.rmi.ssl,javax.script,javax.security.auth,javax.security.auth.callback,javax.security.auth.kerberos,javax.security.auth.login,javax.security.auth.spi,javax.security.auth.x500,javax.security.cert,javax.security.sasl,javax.sound.midi,javax.sound.midi.spi,javax.sound.sampled,javax.sound.sampled.spi,javax.sql,javax.sql.rowset,javax.sql.rowset.serial,javax.sql.rowset.spi,javax.swing,javax.swing.border,javax.swing.colorchooser,javax.swing.event,javax.swing.filechooser,javax.swing.plaf,javax.swing.plaf.basic,javax.swing.plaf.metal,javax.swing.plaf.multi,javax.swing.plaf.nimbus,javax.swing.plaf.synth,javax.swing.table,javax.swing.text,javax.swing.text.html,javax.swing.text.html.parser,javax.swing.text.rtf,javax.swing.tree,javax.swing.undo,javax.tools,javax.transaction,javax.transaction.xa,javax.xml,javax.xml.bind,javax.xml.bind.annotation,javax.xml.bind.annotation.adapters,javax.xml.bind.attachment,javax.xml.bind.helpers,javax.xml.bind.util,javax.xml.crypto,javax.xml.crypto.dom,javax.xml.crypto.dsig,javax.xml.crypto.dsig.dom,javax.xml.crypto.dsig.keyinfo,javax.xml.crypto.dsig.spec,javax.xml.datatype,javax.xml.namespace,javax.xml.parsers,javax.xml.soap,javax.xml.stream,javax.xml.stream.events,javax.xml.stream.util,javax.xml.transform,javax.xml.transform.dom,javax.xml.transform.sax,javax.xml.transform.stax,javax.xml.transform.stream,javax.xml.validation,javax.xml.ws,javax.xml.ws.handler,javax.xml.ws.handler.soap,javax.xml.ws.http,javax.xml.ws.soap,javax.xml.ws.spi,javax.xml.ws.spi.http,javax.xml.ws.wsaddressing,javax.xml.xpath,org.ietf.jgss,org.omg.CORBA,org.omg.CORBA_2_3,org.omg.CORBA_2_3.portable,org.omg.CORBA.DynAnyPackage,org.omg.CORBA.ORBPackage,org.omg.CORBA.portable,org.omg.CORBA.TypeCodePackage,org.omg.CosNaming,org.omg.CosNaming.NamingContextExtPackage,org.omg.CosNaming.NamingContextPackage,org.omg.Dynamic,org.omg.DynamicAny,org.omg.DynamicAny.DynAnyFactoryPackage,org.omg.DynamicAny.DynAnyPackage,org.omg.IOP,org.omg.IOP.CodecFactoryPackage,org.omg.IOP.CodecPackage,org.omg.Messaging,org.omg.PortableInterceptor,org.omg.PortableInterceptor.ORBInitInfoPackage,org.omg.PortableServer,org.omg.PortableServer.CurrentPackage,org.omg.PortableServer.POAManagerPackage,org.omg.PortableServer.POAPackage,org.omg.PortableServer.portable,org.omg.PortableServer.ServantLocatorPackage,org.omg.SendingContext,org.omg.stub.java.rmi,org.w3c.dom,org.w3c.dom.bootstrap,org.w3c.dom.css,org.w3c.dom.events,org.w3c.dom.html,org.w3c.dom.ls,org.w3c.dom.ranges,org.w3c.dom.stylesheets,org.w3c.dom.traversal,org.w3c.dom.views,org.w3c.dom.xpath,org.xml.sax,org.xml.sax.ext,org.xml.sax.helpers
org.osgi.framework.uuid=b02dbff1-6195-0011-1c93-c31f10751197
org.osgi.framework.vendor=Eclipse
org.osgi.framework.version=1.7.0
org.osgi.supports.framework.extension=true
org.osgi.supports.framework.fragment=true
org.osgi.supports.framework.requirebundle=true
os.arch=amd64
os.name=Windows 7
os.version=6.1
osgi.arch=x86_64
osgi.bundles=reference:file:javax.transaction_1.1.1.v201105210645.jar,reference:file:org.eclipse.equinox.simpleconfigurator_1.0.300.v20110815-1744.jar@1:start
osgi.bundles.defaultStartLevel=4
osgi.bundlestore=C:\Users\jongw\My Programs\eclipse3.8M6\eclipse\configuration\org.eclipse.osgi\bundles
osgi.configuration.area=file:/C:/Users/jongw/My Programs/eclipse3.8M6/eclipse/configuration/
osgi.framework=file:/c:/Users/jongw/My Programs/eclipse3.8M6/eclipse/plugins/org.eclipse.osgi_3.8.0.v20120312-2035.jar
osgi.framework.extensions=reference:file:javax.transaction_1.1.1.v201105210645.jar
osgi.framework.shape=jar
osgi.framework.version=3.8.0.v20120312-2035
osgi.frameworkClassPath=., file:c:/Users/jongw/My Programs/eclipse3.8M6/eclipse/plugins/javax.transaction_1.1.1.v201105210645.jar
osgi.install.area=file:/C:/Users/jongw/My Programs/eclipse3.8M6/eclipse/
osgi.instance.area=file:/C:/Users/jongw/workspaces/junoecftest/
osgi.instance.area.default=file:/C:/Users/jongw/workspace/
osgi.logfile=C:\Users\jongw\workspaces\junoecftest\.metadata\.log
osgi.manifest.cache=C:\Users\jongw\My Programs\eclipse3.8M6\eclipse\configuration\org.eclipse.osgi\manifests
osgi.nl=en_US
osgi.os=win32
osgi.requiredJavaVersion=1.5
osgi.splashLocation=C:\Users\jongw\My Programs\eclipse3.8M6\eclipse\\plugins\org.eclipse.platform_4.2.0.v20120315-1300\splash.bmp
osgi.splashPath=platform:/base/plugins/org.eclipse.platform
osgi.syspath=c:\Users\jongw\My Programs\eclipse3.8M6\eclipse\plugins
osgi.tracefile=C:\Users\jongw\workspaces\junoecftest\.metadata\trace.log
osgi.ws=win32
path.separator=;
sun.arch.data.model=64
sun.boot.class.path=C:\Program Files\Java\jre7\lib\resources.jar;C:\Program Files\Java\jre7\lib\rt.jar;C:\Program Files\Java\jre7\lib\sunrsasign.jar;C:\Program Files\Java\jre7\lib\jsse.jar;C:\Program Files\Java\jre7\lib\jce.jar;C:\Program Files\Java\jre7\lib\charsets.jar;C:\Program Files\Java\jre7\classes
sun.boot.library.path=C:\Program Files\Java\jre7\bin
sun.cpu.endian=little
sun.cpu.isalist=amd64
sun.desktop=windows
sun.io.unicode.encoding=UnicodeLittle
sun.java.command=C:\Users\jongw\My Programs\eclipse3.8M6\eclipse\\plugins/org.eclipse.equinox.launcher_1.3.0.v20120308-1358.jar -os win32 -ws win32 -arch x86_64 -showsplash C:\Users\jongw\My Programs\eclipse3.8M6\eclipse\\plugins\org.eclipse.platform_4.2.0.v20120315-1300\splash.bmp -launcher C:\Users\jongw\My Programs\eclipse3.8M6\eclipse\eclipse.exe -name Eclipse --launcher.library C:\Users\jongw\My Programs\eclipse3.8M6\eclipse\\plugins/org.eclipse.equinox.launcher.win32.win32.x86_64_1.1.200.v20110908-1331\eclipse_1500.dll -startup C:\Users\jongw\My Programs\eclipse3.8M6\eclipse\\plugins/org.eclipse.equinox.launcher_1.3.0.v20120308-1358.jar --launcher.overrideVmargs -exitdata 1c8c_5c -product org.eclipse.epp.package.jee.product -vm C:\Windows\system32\javaw.exe -vmargs -Dosgi.requiredJavaVersion=1.5 -Xms40m -Xmx512m -XX:MaxPermSize=256m -jar C:\Users\jongw\My Programs\eclipse3.8M6\eclipse\\plugins/org.eclipse.equinox.launcher_1.3.0.v20120308-1358.jar
sun.java.launcher=SUN_STANDARD
sun.jnu.encoding=Cp1252
sun.management.compiler=HotSpot 64-Bit Tiered Compilers
sun.os.patch.level=Service Pack 1
user.country=US
user.country.format=NL
user.dir=C:\Users\jongw\My Programs\eclipse3.8M6\eclipse
user.home=C:\Users\jongw
user.language=en
user.language.format=nl
user.name=jongw
user.script=
user.timezone=Europe/Berlin
user.variant=

============================
Comment 10 Scott Lewis CLA 2012-05-05 12:01:24 EDT
Please retry with java 7...with install from here

http://download.eclipse.org/rt/ecf/3.5Test/site.p2 

This repo has both .jar and .jar.pack.gz files.
Comment 11 Wim Jongman CLA 2012-05-07 06:12:42 EDT
All is fine now.
Comment 12 Scott Lewis CLA 2012-05-07 10:44:12 EDT
Given comment 11, I'm going to resolve this bug.  It's unfortunate that we have to include both jar an .gz files to work around this (for size), but so be it.
Comment 13 Markus Duft CLA 2014-12-19 03:34:04 EST
I think this needs a REOPEN. This happens with Luna and Java 8 using both the 3.9.0 and 3.9.1 update sites when trying to put  org.eclipse.ecf.remoteservice.sdk.feature.feature.group in a target platform.
Comment 14 Scott Lewis CLA 2014-12-19 10:44:09 EST
(In reply to Markus Duft from comment #13)
> I think this needs a REOPEN. This happens with Luna and Java 8 using both
> the 3.9.0 and 3.9.1 update sites when trying to put 
> org.eclipse.ecf.remoteservice.sdk.feature.feature.group in a target platform.

Are you getting the same errors on attempted installation as when this bug was opened i.e. 

https://bugs.eclipse.org/bugs/show_bug.cgi?id=376306#c0

or is it some new error?  In either case, please paste into a comment any of the error notices (in log etc) that you can to help with diagnosis.
Comment 15 Scott Lewis CLA 2014-12-19 12:47:23 EST
(In reply to Markus Duft from comment #13)
> I think this needs a REOPEN. This happens with Luna and Java 8 using both
> the 3.9.0 and 3.9.1 update sites when trying to put 
> org.eclipse.ecf.remoteservice.sdk.feature.feature.group in a target platform.

Hi Markus.   I (Scott) am finalizing work on ECF 3.9.2, due to be released on Monday Dec 22nd.   I would very much like to try to address+fix this bug for 3.9.2, so I would appreciate as much info about what you are experiencing as quickly as possible.  

I will attempt to reproduce myself, but I would still like to get as much information as possible about what you are experiencing WRT Java8, Luna (SR1 I assume), and installation of the remoteservice.sdk.feature into a target platform. 

Thanksinadvance.
Comment 16 Denis Roy CLA 2014-12-19 12:48:38 EST
> I will attempt to reproduce myself,

Let us know how that works out   =)
Comment 17 Markus Duft CLA 2014-12-19 12:56:22 EST
Hey, nice to see that ur taking care of this :) I just mirrored the plain 3.9.1 update site and tried to add this to our .target file. But that yielded a md5 verification error for the embedded xmpp .jar file for the .source bundle. I hope that's clear enough, we're on an x-mas party right now :)
Comment 18 Scott Lewis CLA 2014-12-19 13:09:17 EST
(In reply to Markus Duft from comment #17)
> Hey, nice to see that ur taking care of this :) 

Well, if it's the same issue as before (problem in jvm) I'm not sure what I will be able to do about it, but will do what I can.

>I just mirrored the plain
> 3.9.1 update site and tried to add this to our .target file. But that
> yielded a md5 verification error for the embedded xmpp .jar file for the
> .source bundle. 

That's very weird.

>I hope that's clear enough, we're on an x-mas party right
> now :)

Could you indicate:

What exact version of jvm are you using (from configuration)?
What exact version of Eclipse are you using?
How are you adding the ECF rs sdk to your target platform?  (e.g. as p2/update site, plugins from directory?)
Other than the ECF feature you are trying to add, what's in this target?

It would also be great if you could paste in the error...from log?

One work around to try would be to not include the source.
Comment 19 Scott Lewis CLA 2014-12-19 13:30:41 EST
Created attachment 249558 [details]
java8+lunasr1+ecf rs sdk 3.9.1 configuration

Unfortunately, I'm having trouble reproducing this with Java8/Eclipse Luna SR1/ECF 3.9.1.

Here's my configuration

JDK:  java.runtime.version=1.8.0-b132
Eclipse:  eclipse.buildId=4.4.1.M20140925-0400
ECF 3.9.1:  http://download.eclipse.org/rt/ecf/3.9.1/site.p2

ECF RS SDK and source added to Running Platform target platform.

So please do let me know what your configuration is, as the problem you are experiencing appears to be jdk version/Eclipse version/target platform contents specific.
Comment 20 David Williams CLA 2014-12-19 13:44:20 EST
I have only skim read this bug, so sorry if I am saying something not relevant, but some of the messages remind me of those received when there is a "packed jar" inside of another jar (or bundle). 

We used to do that routinely, but discovered starting with Java 7 that does not work. (bug 361628). In fact, I just noticed bug 361628 comment 29 :)

While since those "old days" we've made progress on fixing things on the "bundles delivered" side, if you using an old enough version, with a modern VM, it may not contain the fix. 

One work-around, for the "client side" is to specify a "pack200" processor from a Java 6 VM ... allows you to continue to use your modern VM, but when a "pack200" operation is needed, p2 will use the executable pointed to by the environment variable. See http://wiki.eclipse.org/JarProcessor_Options

If my "skim read" is valid at all, something like starting eclipse with 

-Dorg.eclipse.update.jarprocessor.pack200=<absolutepathToJava6directorythatContains_pack200_and_unpack200>

HTH
Comment 21 Scott Lewis CLA 2014-12-19 14:14:37 EST
(In reply to David Williams from comment #20)
> I have only skim read this bug, so sorry if I am saying something not
> relevant, but some of the messages remind me of those received when there is
> a "packed jar" inside of another jar (or bundle). 

Yes on the surface it does.  

Since the original reporting of this problem, however, ECF has included both .jar and .jar.pack files as a reliable workaround.  Has something changed that would prevent this workaround (having .jar and .jar.pack files in repo) from continuing to function?

> 
> We used to do that routinely, but discovered starting with Java 7 that does
> not work. (bug 361628). In fact, I just noticed bug 361628 comment 29 :)
> 
> While since those "old days" we've made progress on fixing things on the
> "bundles delivered" side, if you using an old enough version, with a modern
> VM, it may not contain the fix. 

Not sure who you mean WRT 'using an old enough version'.  Do you mean in the builder/releng (ECF) or do you mean in the 'target' (i.e. Markus' installation...which is apparently java8+Luna)?
Comment 22 David Williams CLA 2014-12-19 16:10:31 EST
(In reply to Scott Lewis from comment #21)
.  
> 
> Since the original reporting of this problem, however, ECF has included both
> .jar and .jar.pack files as a reliable workaround.  Has something changed
> that would prevent this workaround (having .jar and .jar.pack files in repo)
> from continuing to function?

Should work. 

> Not sure who you mean WRT 'using an old enough version'.  Do you mean in the
> builder/releng (ECF) or do you mean in the 'target' (i.e. Markus'
> installation...which is apparently java8+Luna)?

I just meant I could not recall "when" we started to fix the jars on eclipse.org, if it was Luna, Luna SR1, or Juno ... poor memory and skim reading. 

Just trying to help. But from your response, sounds like "old news".
Comment 23 Markus Duft CLA 2014-12-22 01:12:27 EST
Created attachment 249584 [details]
the list of mirrored (or downloaded) update sites that is included in the p2 composite site

I have mirrored a few update sites (list attached). All these sites are thrown together on one big pile (p2 composite site), and then I use the attached .target file :)
Comment 24 Markus Duft CLA 2014-12-22 01:15:14 EST
Created attachment 249585 [details]
the .target file we use (for real this time)

oh, sorry, the first one was the list of mirrored (or downloaded) update sites in our composite site. this one now is the .target file we use in eclipse.
Comment 25 Scott Lewis CLA 2014-12-22 11:06:41 EST
(In reply to Markus Duft from comment #24)
> Created attachment 249585 [details]
> the .target file we use (for real this time)
> 
> oh, sorry, the first one was the list of mirrored (or downloaded) update
> sites in our composite site. this one now is the .target file we use in
> eclipse.

Hi Markus.

I've looked at the target file.  My initial guess is that your mirroring process  defeats ECF's inclusion of both .jar and .jar.pack files as a workaround for this non-ECf bug as mentioned in comment 21.  Without both the .jar and .jar.pack files in your mirror repo, you experience the problem again.

To verify this, could you please try installing the ECF 3.9.2 RS SDK (released today) into this or some other target that accesses the ECF repo directly/without the mirroring?  My suspicion is that will work fine.  If it does, then we can discuss additional work-arounds/solutions for you and your mirroring process.
Comment 26 Markus Duft CLA 2014-12-22 11:18:21 EST
Hey,

Instantly wanted to try it, but unfortunately it seems that the download site is down at the moment "SQL Trouble: Connection timed out".

I checked what I have here, and it seems that the mirrored site contains a .jar and a .jar.pack.gz file for (nearly) all bundles. Especially the jivesoftware.smack.source one has both. In the meantime I just removed the smack.source bundle and regenerated the site meta-data, which works for me. I just hate to post-process things I get from upstream ;)

these are the commands used to mirror:

 ${ECLIPSE} -nosplash -application org.eclipse.equinox.p2.metadata.repository.mirrorApplication         -source $src -destination $dst -destinationName $dstName -verbose -compare
 ${ECLIPSE} -nosplash -application org.eclipse.equinox.p2.artifact.repository.mirrorApplication         -source $src -destination $dst -destinationName $dstName -verbose -compare

I'll see if I have some time tomorrow to retest (if the servers are back up by then).
Comment 27 Scott Lewis CLA 2014-12-22 12:09:53 EST
(In reply to Markus Duft from comment #26)
> Hey,
> 
> Instantly wanted to try it, but unfortunately it seems that the download
> site is down at the moment "SQL Trouble: Connection timed out".

Hmm.  Is this the repo url you are using?

http://download.eclipse.org/rt/ecf/staging/3.9.2/site.p2

This is responding fine for me at the moment.  If the above continues for you please let the eclipse webmasters know and also let know on this bug and we'll try to determine what's up.

> 
> I checked what I have here, and it seems that the mirrored site contains a
> .jar and a .jar.pack.gz file for (nearly) all bundles. Especially the
> jivesoftware.smack.source one has both. In the meantime I just removed the
> smack.source bundle and regenerated the site meta-data, which works for me.
> I just hate to post-process things I get from upstream ;)

Well, one option would be to contribute desired (post) processing back to the upstream project.  I can tell you that for ECF at least, such releng contributions would be welcomed.

> 
> these are the commands used to mirror:
> 
>  ${ECLIPSE} -nosplash -application
> org.eclipse.equinox.p2.metadata.repository.mirrorApplication         -source
> $src -destination $dst -destinationName $dstName -verbose -compare
>  ${ECLIPSE} -nosplash -application
> org.eclipse.equinox.p2.artifact.repository.mirrorApplication         -source
> $src -destination $dst -destinationName $dstName -verbose -compare

David, do you know how p2 mirrorApplication handles .jar and .jar.pack files?  I could easily imagine that even if it copies all the files (as Markus suggests it might be doing) that perhaps it doesn't generate the right meta-data for non pack repos?
Comment 28 Markus Duft CLA 2014-12-23 01:34:06 EST
I was trying to reach https://eclipse.org/ecf/downloads.php :)

I tried now, and when I use the site hosted on the eclipse.org servers, it seems to work.

I now downloaded the P2 archive from the download section, so I don't have to mirror myself - that works better, no problems with that one at all.
Comment 29 Scott Lewis CLA 2014-12-23 03:10:00 EST
(In reply to Markus Duft from comment #28)
> I was trying to reach https://eclipse.org/ecf/downloads.php :)
> 
> I tried now, and when I use the site hosted on the eclipse.org servers, it
> seems to work.
> 
> I now downloaded the P2 archive from the download section, so I don't have
> to mirror myself - that works better, no problems with that one at all.

Ok, thanks for the test.  I'm going to assume that something about the mirroring process (or the p2 mirror program) was messing up the presence of both the jar and .pack files, and that this was causing the pack bug to reappear.  Resolving as fixed.

FWIW, I would like to see our releng updated to use the fix described by D Williams in comment 20. Opened up bug 456052 to track this change.