Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 375861

Summary:	Request new png files for compare widget.
Product:	[ECD] Orion	Reporter:	libing wang <libingw>
Component:	Client	Assignee:	Anton McConville <antonm>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	simon_kaegi
Version:	0.4
Target Milestone:	2.0 M1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description libing wang

2012-04-02 13:32:48 EDT

In 0.5, we are planning to add some major improvements:

1.Word diff. We already have line diff and presented as blocks.
We need need 4 png files on navigating blocks and word diffs inside it.
Next block, previous block, next word diff and previous word diff.
We are already using up and down arrow PNGs for block navigation but I think we need 4 brand new PNGs now.

2.Copy from left to right.
This will replace the current diff(block or word level) from right(old) to left(new). We are using the left arrow arrow PNG but I don't think it is intuitive.

3.Switch between two-way and inline mode in the compare widget.
We will consolidate the inline and two-way into one widget by adding a switcher.
We need a PNG file for this command.

Comment 1 Susan McCourt

2012-04-02 13:40:38 EDT

Note that we typically use text in toolbars and section headers, so it's possible some of these will be text rather than icons.  We use icons in toolbars and headers only for directional or other icons where a simple arrow, etc. is more obvious than describing the action in words.  If something requires more than the basic directions, we need to decide if text would better express it.

(In reply to comment #0)
> In 0.5, we are planning to add some major improvements:
> 
> 1.Word diff. We already have line diff and presented as blocks.
> We need need 4 png files on navigating blocks and word diffs inside it.
> Next block, previous block, next word diff and previous word diff.
> We are already using up and down arrow PNGs for block navigation but I think we
> need 4 brand new PNGs now.

Will have to try this out to understand what is needed.  I don't yet understand how next block/prev block is different than next word/prev word.  We can discuss further when there's something to try.

> 
> 2.Copy from left to right.
> This will replace the current diff(block or word level) from right(old) to
> left(new). We are using the left arrow arrow PNG but I don't think it is
> intuitive.

Will have to try.  If a left arrow is not intuitive then we would probably switch to text.

> 
> 3.Switch between two-way and inline mode in the compare widget.
> We will consolidate the inline and two-way into one widget by adding a
> switcher.
> We need a PNG file for this command.

This will likely be done with text.  Most other web diff tools (github, gerrit, eclipse git viewer) use text for this as well.

Comment 2 Anton McConville

2013-02-07 13:45:54 EST

Closing