Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 375412

Summary: [Theming] [Group] Group's padding makes proper layouting difficult
Product: [RT] RAP Reporter: Nick Mussin <nmussin>
Component: RWTAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: tbuschto
Version: 1.5   
Target Milestone: 1.5 M7   
Hardware: All   
OS: All   
Whiteboard:

Description Nick Mussin CLA 2012-03-27 09:23:56 EDT 
Currently the Group's default theme dictates a padding of some pixels. This padding can be problematic in situations where one's trying to left-align widgets with a SWT layout manager. Bringing widgets in line within a layout is frequently needed while designing user interfaces and should be done by layout managers and not by the theming.
Comment 1 Tim Buschtoens CLA 2012-03-27 09:39:54 EDT 
We already had this in default.css shortly, but i reverted the changes. I'm not conviced this is a good idea. Setting the padding to 0 made the controls demo look broken, and it would have broken all layouts already based on the default padding. 

(Note that this was only changed in the new [1.5] default theming. Everything based on business/fancy theme would have been fine - but if we change this in the default, shouldn't it be also in the other themes?)

Left aligning something in a group is a valid, but rather rare usecase, and having a default padding seems to be more worth to me. Since having no padding looks pretty bad most of the time, all layouts within groups would have to be changed to explicitly have this padding - something that can't be done by constructor, so it can add 2 or 3 lines of code every time.

If the padding needs to be 0, a theming contribution with or without a custom variant could be used.

Also, the padding provided was "15px 0px 0px 0px" because of the label at the frames top, so the logic would be somewhat inconsistent.

So, any other opinions  on this issue?
Comment 2 Ralf Sternberg CLA 2012-04-22 11:56:19 EDT 
This may have been a misunderstanding between Nick and me, we've discussed the margin that has been introduced with the new theme. This margin breaks the alignment of Groups in a layout and should be removed. The padding is ok, IMO.
Comment 3 Ivan Furnadjiev CLA 2012-05-04 05:56:13 EDT 
Fixed by adjusting the Group-Frame margin property (only top margin left).