Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 375192

Summary: Table oddities
Product: [Tools] Linux Tools Reporter: Andrew Overholt <overholt>
Component: GProfAssignee: Xavier Raynaud <xraynaud>
Status: CLOSED FIXED QA Contact: Xavier Raynaud <xraynaud>
Severity: normal    
Priority: P3 CC: akurtakov, lilia.ghachem
Version: 0.9.2   
Target Milestone: 2.0   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
illustrative screenshot none

Description Andrew Overholt CLA 2012-03-23 11:26:19 EDT
Created attachment 213105 [details]
illustrative screenshot

There are some UI oddities in the GProf tables.  It would be nice to clean this up to have a more polished look.  Issues I see include:

- %Time title is odd.  Maybe add a space in between '%' and 'Time'?
- the %Time column is very wide and the Name column is very narrow meaning only very short function names can be seen without re-sizing that column
- the colourization doesn't fill the entire %Time cells.  There is a slight section of transparency to the left of the coloured cell data.

I'll attach a screenshot to illustrate.
Comment 1 Xavier Raynaud CLA 2012-03-23 12:22:03 EDT
Hi,

Partially resolved by commit fdf6afd21f02135c7b1ee74a1589184c243c2c5e

- change "%Time" by "% Time"
- extends default width of Name column to 250 pixels by default

Note: The default width of "%Time" column is 100 pixels.
      SWT automatically expand the last column when there is remaining space.
      Have you a suggestion for a better behaviour ?

Note 2: Columns width are saved when user modify them (and applied next time user open gprof view)
Comment 2 Andrew Overholt CLA 2012-03-23 20:44:40 EDT
(In reply to comment #1)
> Hi,
> 
> Partially resolved by commit fdf6afd21f02135c7b1ee74a1589184c243c2c5e
> 
> - change "%Time" by "% Time"
> - extends default width of Name column to 250 pixels by default

This seems like a good plan.  Can it be a percentage of the table width instead in case of low screen resolutions?

> Note: The default width of "%Time" column is 100 pixels.
>       SWT automatically expand the last column when there is remaining space.
>       Have you a suggestion for a better behaviour ?

No :)

> Note 2: Columns width are saved when user modify them (and applied next time
> user open gprof view)

Cool.
Comment 3 Alexander Kurtakov CLA 2013-02-19 04:21:47 EST
Xavier, what's the status here?
Comment 4 Xavier Raynaud CLA 2013-02-19 05:11:41 EST
The only thing not done is "There is a slight section of transparency to the left of the coloured cell data" (on linux)

But I'm afraid we can't fix. It depends on some obscure GTK settings.