Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 374894

Summary: [ActionSets] [Contributions] WWinPluginActions need to clean up on part close
Product: [Eclipse Project] Platform Reporter: Paul Webster <pwebster>
Component: UIAssignee: Platform UI Triaged <platform-ui-triaged>
Status: RESOLVED WORKSFORME QA Contact:
Severity: major    
Priority: P3 CC: axel.richard, daniel_megert, emoffatt, ob1.eclipse, psuzzi
Version: 4.2   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
URL: http://download.eclipse.org/eclipse/downloads/drops4/I20120321-0610/results/html/org.eclipse.jdt.ui.tests_linux.gtk.x86_64.html
Whiteboard: candidate43
Bug Depends on: 319704    
Bug Blocks:    

Description Paul Webster CLA 2012-03-21 09:20:52 EDT 
ActionSets are generated into the main toolbar and main menubar, on top of the Eclipse 4 model.

But now the WWinPluginActions need to clean up on part close.  See LeakTestSuite in the jdt.ui tests.



	Expected instance count: 0, actual: 1 Element 0 org.eclipse.ui.editors.text.TextEditor org.eclipse.search2.internal.ui.text2.FindInFileActionDelegate#fEditor -> org.eclipse.ui.editors.text.TextEditor@45960997 org.eclipse.ui.internal.PluginAction#delegate -> org.eclipse.search2.internal.ui.text2.FindInFileActionDelegate@4b71b026 java.lang.Object[35] -> org.eclipse.ui.internal.WWinPluginAction@15e1df6e java.util.ArrayList#elementData -> [Ljava.lang.Object;@3f8af105 org.eclipse.ui.internal.WWinPluginAction#staticActionList -> [org.eclipse.ui.internal.WWinPluginPulldown@8094cc7, org.eclipse.ui.internal.WWinPluginAction@6a754 java.lang.Class -> class org.eclipse.ui.internal.WWinPluginAction

junit.framework.AssertionFailedError: Expected instance count: 0, actual: 1
Element 0
org.eclipse.ui.editors.text.TextEditor
org.eclipse.search2.internal.ui.text2.FindInFileActionDelegate#fEditor -> org.eclipse.ui.editors.text.TextEditor@45960997
org.eclipse.ui.internal.PluginAction#delegate -> org.eclipse.search2.internal.ui.text2.FindInFileActionDelegate@4b71b026
java.lang.Object[35] -> org.eclipse.ui.internal.WWinPluginAction@15e1df6e
java.util.ArrayList#elementData -> [Ljava.lang.Object;@3f8af105
org.eclipse.ui.internal.WWinPluginAction#staticActionList -> [org.eclipse.ui.internal.WWinPluginPulldown@8094cc7, org.eclipse.ui.internal.WWinPluginAction@6a754
java.lang.Class -> class org.eclipse.ui.internal.WWinPluginAction


at org.eclipse.jdt.ui.leaktest.LeakTestCase.assertInstanceCount(LeakTestCase.java:127)
at org.eclipse.jdt.ui.tests.leaks.JavaLeakTest.testTextEditorCloseOneOfTwo(JavaLeakTest.java:112)
at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
at junit.extensions.TestSetup.run(TestSetup.java:27)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:416)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:249)
at org.eclipse.test.UITestApplication$2.run(UITestApplication.java:197)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3528)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3181)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1016)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:910)
at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:85)
at org.eclipse.ui.internal.Workbench$4.run(Workbench.java:580)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:535)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
at org.eclipse.test.UITestApplication.runApplication(UITestApplication.java:140)
at org.eclipse.test.UITestApplication.run(UITestApplication.java:62)
at org.eclipse.test.UITestApplication.start(UITestApplication.java:212)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:353)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:180)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:629)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:584)
at org.eclipse.equinox.launcher.Main.run(Main.java:1438)
at org.eclipse.equinox.launcher.Main.main(Main.java:1414)
at org.eclipse.core.launcher.Main.main(Main.java:34)
Comment 1 Paul Webster CLA 2013-01-11 14:02:48 EST 
Defered to 4.3
Comment 2 Axel RICHARD CLA 2016-02-03 04:23:02 EST 
Paul,

I didn't succeed to reproduce the problem describe in this bug.
Could you try to reproduce it and update the bug status or explain me more precisely how to reproduce it please ?

Thank you
Comment 3 Dani Megert CLA 2016-02-09 08:46:46 EST 
(In reply to Axel RICHARD from comment #2)
> Paul,
> 
> I didn't succeed to reproduce the problem describe in this bug.
> Could you try to reproduce it and update the bug status or explain me more
> precisely how to reproduce it please ?
> 
> Thank you

I think we're good here. The LeakTestSuite runs fine these days.
Comment 4 Axel RICHARD CLA 2016-02-12 03:30:03 EST 
(In reply to Dani Megert from comment #3)
> (In reply to Axel RICHARD from comment #2)
> > Paul,
> > 
> > I didn't succeed to reproduce the problem describe in this bug.
> > Could you try to reproduce it and update the bug status or explain me more
> > precisely how to reproduce it please ?
> > 
> > Thank you
> 
> I think we're good here. The LeakTestSuite runs fine these days.

Ok, so may be the team could close the bug ? Thanks

Best Regards,