Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 374659

Summary:	NPE when running the Workbench Demo
Product:	[RT] RAP	Reporter:	Ivan Furnadjiev <ivan>
Component:	Workbench	Assignee:	Project Inbox <rap-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P1
Version:	1.5
Target Milestone:	1.5 M6
Hardware:	All
OS:	All
Whiteboard:

Description Ivan Furnadjiev

2012-03-19 10:59:28 EDT

Removing the deprecated Graphics#getCursor (bug 342594) we introduced the following NPE in the Workbench Demo:
java.lang.NullPointerException
	at org.eclipse.ui.internal.layout.TrimCommonUIHandle.setDragCursor(TrimCommonUIHandle.java:324)
	at org.eclipse.ui.internal.layout.TrimCommonUIHandle.setup(TrimCommonUIHandle.java:181)
	at org.eclipse.ui.internal.layout.TrimCommonUIHandle.<init>(TrimCommonUIHandle.java:153)
	at org.eclipse.ui.internal.layout.TrimLayout.addTrim(TrimLayout.java:221)
	at org.eclipse.ui.internal.layout.TrimLayout.addTrim(TrimLayout.java:195)
	at org.eclipse.ui.internal.WorkbenchWindow.updateLayoutDataForContents(WorkbenchWindow.java:3894)
	at org.eclipse.ui.internal.WorkbenchWindow.setLayoutDataForContents(WorkbenchWindow.java:3920)
	at org.eclipse.ui.internal.WorkbenchWindow.createDefaultContents(WorkbenchWindow.java:1201)
	at org.eclipse.ui.internal.WorkbenchWindowConfigurer.createDefaultContents(WorkbenchWindowConfigurer.java:671)
	at org.eclipse.ui.application.WorkbenchWindowAdvisor.createWindowContents(WorkbenchWindowAdvisor.java:269)
	at org.eclipse.ui.internal.WorkbenchWindow.createContents(WorkbenchWindow.java:1015)
	at org.eclipse.jface.window.Window.create(Window.java:444)
	at org.eclipse.ui.internal.Workbench$17.runWithException(Workbench.java:1254)
	at org.eclipse.ui.internal.StartupThreading$StartupRunnable.run(StartupThreading.java:32)
	at org.eclipse.swt.widgets.Synchronizer.syncExec(Synchronizer.java:229)
	at org.eclipse.ui.internal.UISynchronizer.syncExec(UISynchronizer.java:150)
	at org.eclipse.swt.widgets.Display.syncExec(Display.java:1061)
	at org.eclipse.ui.internal.StartupThreading.runWithoutExceptions(StartupThreading.java:110)
	at org.eclipse.ui.internal.Workbench.busyOpenWorkbenchWindow(Workbench.java:1251)
	at org.eclipse.ui.internal.Workbench.doOpenFirstTimeWindow(Workbench.java:2062)
	at org.eclipse.ui.internal.Workbench.openFirstTimeWindow(Workbench.java:1993)
	at org.eclipse.ui.internal.WorkbenchConfigurer.openFirstTimeWindow(WorkbenchConfigurer.java:188)
	at org.eclipse.ui.application.WorkbenchAdvisor.openWindows(WorkbenchAdvisor.java:790)
	at org.eclipse.ui.internal.Workbench$27.runWithException(Workbench.java:1641)
	at org.eclipse.ui.internal.StartupThreading$StartupRunnable.run(StartupThreading.java:32)
	at org.eclipse.swt.widgets.Synchronizer.syncExec(Synchronizer.java:229)
	at org.eclipse.ui.internal.UISynchronizer.syncExec(UISynchronizer.java:150)
	at org.eclipse.swt.widgets.Display.syncExec(Display.java:1061)
	at org.eclipse.ui.internal.StartupThreading.runWithoutExceptions(StartupThreading.java:110)
	at org.eclipse.ui.internal.Workbench.init(Workbench.java:1636)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2655)
	at org.eclipse.ui.internal.Workbench.access$5(Workbench.java:2530)
	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:702)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:685)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:157)
	at org.eclipse.rap.demo.DemoWorkbench.createUI(DemoWorkbench.java:42)
	at org.eclipse.rwt.internal.lifecycle.RWTLifeCycle.createUI(RWTLifeCycle.java:177)
	at org.eclipse.rwt.internal.lifecycle.RWTLifeCycle$UIThreadController.run(RWTLifeCycle.java:289)
	at java.lang.Thread.run(Thread.java:722)
	at org.eclipse.rwt.internal.lifecycle.UIThread.run(UIThread.java:101)

Comment 1 Ivan Furnadjiev

2012-03-19 11:15:15 EDT

Fixed by un-commenting the initialization of toDrag control in TrimCommonUIHandle.