Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 374261

Summary:	visual design pass for page specific colors
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	libingw, Silenio_Quarti
Version:	0.4
Target Milestone:	1.0 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2012-03-14 11:46:35 EDT

The Orion page banner/header/content in general use shades of black/gray, blue link color, and the gold logo/icon color.  

However in certain pages we need to use more colors, and we've never had a designer take a look at the RGB's for tweaking.

We should look at the extra colors in 0.5.  What comes to mind:

- editor current line, search highlight, current search highlight
- diff colors (removal, delete, current removal/delete etc.)
- navigator cursor color (maybe we should move to a dotted line or something)

Comment 1 Susan McCourt

2012-04-12 13:44:05 EDT

With char/block level diff, we now have three shades of green/red to show diffs.  I think we could tweak these a little.

Comment 2 libing wang

2012-04-17 14:28:12 EDT

(In reply to comment #1)
> With char/block level diff, we now have three shades of green/red to show
> diffs.  I think we could tweak these a little.

Actually 4 shades, block, current block, word, current word.
Also, in the conflicting case , in the side by side , both blocks are represented by light yellow as normal and dark yellow as current block. 
Conflicting blocks in the inline widgets are presented by yellow as well, where you can not distinguish deleting and adding block but you can tell by the word colors inside it.

Comment 3 Susan McCourt

2012-05-11 17:24:32 EDT

I lightened up the "row navigation cursor" color considerably and changed the cursor to dotted.

I still wonder if we could lose the "current row color" completely if the cursor box stands out enough, but this will also be affected by the "selection follows cursor" paradigm. It will be less typical to see them separated once that happens (in bug 377018).

I played around with diff colors but I wasn't seeing the changes take affect.  (Libing, do you know if there is a more limited color palette in the editor?)

Comment 4 Susan McCourt

2012-05-18 15:29:43 EDT

moving out of 0.5M2 to 0.5 milestone until we have more specific buckets for future

Comment 5 Susan McCourt

2012-05-21 16:39:00 EDT

I'd still like to look at the diff colors (in particular the greens) and soften them up.  The reds look okay to me.

Comment 6 Susan McCourt

2012-06-12 11:58:03 EDT

I played with this a little bit, and got the shading to my liking, but it needs more polish to get the "current green" and other greens more differentiated.  Bigger fish to fry right now, moving to 1.0.

Comment 7 Susan McCourt

2012-08-15 17:39:24 EDT

finally got around to changing the diff/added colors from a "sea foam green" to a more traditional green.  That was the last nit in this bug.

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=6ff60f331f0133f1ca8c11b5a360354c6d779909