Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 374118

Summary:	File compare page is blank
Product:	[ECD] Orion	Reporter:	Max Li <maxli>
Component:	Client	Assignee:	libing wang <libingw>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	libingw, susan
Version:	0.5
Target Milestone:	0.5 M1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Max Li

2012-03-13 13:42:35 EDT

1. Open the git log for an individual file.
2. Select two commits.
3. Click compare with each other.
4. The page loaded is blank.

Comment 1 libing wang

2012-03-13 15:45:01 EDT

good catch. Seems the ?readonly part in the URL is no longer working.
It affects the staged file comparasion as well.

Comment 2 libing wang

2012-03-13 18:15:27 EDT

fixed with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=b16771c91a5f3e6cfa8c09ffffcf74ac90a03223.

It took me a while figuring out why this does not work.
I dug into commandGenerator.generateEditorCommands(editor) and tried to comment out all the codes to filter out what helped editor out.
Finally I found out that commandService.addCommandGroup("pageActions", "orion.editorActions.unlabeled", 200) was the key to open the door.

Susan, I am not sure is my fix is just workaround or not. Please help confirm if you have time.
In my commit you will see I used commandService.addCommandGroup just to initialize the "pageAction". And this line just made it works.
But it seems to me that deeper somewhere else in our framework requires that "pageAction" must be registered otherwise the page load will fail.