Bugzilla – Full Text Bug Listing
| Summary: | Styling for active tab in an inactive stack has become worse | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Deepak Azad <deepakazad> | ||||||
| Component: | UI | Assignee: | Platform-UI-Inbox <Platform-UI-Inbox> | ||||||
| Status: | CLOSED DUPLICATE | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | daniel_megert, dominik.wezel, emoffatt, gheorghe, john.arthorne, markus.kell.r, pwebster | ||||||
| Version: | 4.2 | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows 7 | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Deepak Azad
Is this the same on all platforms? PW I see the same thing although I am also on Win 7. There were some CSS problems, especially if using the Appearance page to update, first on GTK, now on Windows, that'll be fixed in I20120315-1300 But when it's working, the 2 styles you should see: 1) the active tab on the active stack should be white, and the rest of the tabs/toolbar background should be platform dependent (I see a blue on windows 7) 2) The active tab on the inactive stack should be a gradient down to white at the bottom, and the rest of the tabs/toolbar background should be white (at least on windows 7) This is much better than the white on white with a dark line that it used to be. I'd be interested in CSS contributions that were an improvement on this, but unless it's much better I don't imagine more than minor tweaks. PW (In reply to comment #3) > But when it's working, the 2 styles you should see: > > 1) the active tab on the active stack should be white, and the rest of the > tabs/toolbar background should be platform dependent (I see a blue on windows > 7) > > 2) The active tab on the inactive stack should be a gradient down to white at > the bottom, and the rest of the tabs/toolbar background should be white (at > least on windows 7) This is what I was complaining about in comment 0. Instead of (2) I would rather color the inactive tabs on the inactive stack a lighter shade of color for inactive tabs on the active stack. > I'd be interested in CSS contributions that were an improvement on this, but > unless it's much better I don't imagine more than minor tweaks. I suppose I can take a shot at this. I guess the best way is to use CSS Spy to figure out what needs to be changed? Talking of minor tweaks, the attachment at bug 372542 comment 3 specifies a 'Keyline Bottom Horz.' but I do not see that in Eclipse. Was that a deliberate omission? (In reply to comment #4) > This is what I was complaining about in comment 0. Instead of (2) I would > rather color the inactive tabs on the inactive stack a lighter shade of color > for inactive tabs on the active stack. > The reason that the inactive stack was white on white was to highlight that it wasn't the focus of what you are now doing in the UI. That metaphor must be maintained with your tweak. PW Created attachment 213755 [details]
White and pale blue tabs standing out on dark theme
Created attachment 213756 [details]
Choosing tab colors has an effect --- but only in the preferences panel
I'm running 4.1 on Gentoo Linux, using the Classic theme on a dark theme. The white / pale blue tabs are standing out in a distracting and odd way in the middle of the otherwise dark theme (see attachment 1 [details]). I hoped to find a general appearance preference to help that, but the ones I tried only worked in the preferences dialog (see attachment 2 [details]). Sorry, wrong attachments. Just check comments 6 and 7 for the right IDs. (In reply to comment #6) > Created attachment 213755 [details] > White and pale blue tabs standing out on dark theme I don't think we have CSS yet to support a dark theme. If you did part of it using preferences then we probably have a scenario where preferences and CSS are trampling over each other. Please open a new bug for that against Platform/UI PW (In reply to Paul Webster from comment #5) > The reason that the inactive stack was white on white was to highlight that > it wasn't the focus of what you are now doing in the UI. That metaphor must > be maintained with your tweak. You can't use white as "active" color and as "inactive" color in the same theme. Bug 378672 explains this in more detail. I think this should be marked as a duplicate of bug 378672 since they are the same topic as far as I can see. *** This bug has been marked as a duplicate of bug 378672 *** |