Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 373850

Summary: Build not optimized
Product: [ECD] Orion Reporter: Mark Macdonald <mamacdon>
Component: RelengAssignee: Project Inbox <orion.releng-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 0.5   
Target Milestone: 0.5 M1   
Hardware: PC   
OS: All   
Whiteboard:

Description Mark Macdonald CLA 2012-03-09 17:00:24 EST
In the latest build deployed on orion.eclipse.org (I20120308-2230), none of the JavaScript is optimized.

The build logs show a bunch of messages like this:

>     [java] Mar 8, 2012 10:35:04 PM com.google.javascript.jscomp.LoggerErrorManager println
>     [java] SEVERE: /opt/public/eclipse/e4/orion/I201203082230/optimization/./edit/built-edit.js:38730: ERROR - Parse error. Internet 
> Explorer has a non-standard intepretation of trailing commas. Arrays will have the wrong length and objects will not parse at all.
>     [java] 				});
>     [java] 				 ^
Comment 1 Mark Macdonald CLA 2012-03-09 17:45:24 EST
Removed some trailing commas:
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e32c4a08c1d262e72fd76e697cb9edcfb86c1f79

This should be fixed now.
Comment 2 Mark Macdonald CLA 2012-03-09 17:51:13 EST
A few things that came to mind which would've made this easier to fix:
- A way to print out the transitive dependency set for a module
- Bug 368176, so you could see these errors without having to open each individual file.