Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 372984

Summary: Fallback theme can appear instead of default theme
Product: [RT] RAP Reporter: Tim Buschtoens <tbuschto>
Component: RWTAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 1.5   
Target Milestone: 1.5 M6   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Qiuck fix none

Description Tim Buschtoens CLA 2012-03-01 10:31:56 EST 
It's possible for the fallback theme to become visible instead of the default theme:

- start a rap server including the demo and design bundles
- start the controls demo like this: localhost:xxxx/business?startup=controls
- controls demo appears in business design
- in the same tab, go to the URL and change "business" to "rap" and hit enter.
- controls demo appears in fallback design
- reload again and default theme appears
Comment 1 Ivan Furnadjiev CLA 2012-03-01 14:31:59 EST 
Created attachment 211907 [details]
Qiuck fix

When you enter a new URL the HTTP session is the same. Session store is not cleared in the GET request, but in the first POST. As a result, StartupPageConfigurer#addThemeDefinitions gets the previous "current" theme from the session store and send it to the ThemeStore.js together with fallback theme. In the first POST request the session store is cleared, the correct current theme is determined and set, but it is missing from the ThemeStore.js.
Comment 2 Ivan Furnadjiev CLA 2012-03-02 01:41:05 EST 
Fixed in StartupPageConfigurer#applyBranding. If there is no branding, default theme is set as current theme.