Bugzilla – Full Text Bug Listing
| Summary: | Installing the sampleCommandsPlugin results in double chevrons in Favorites | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Ken Walker <ken_walker> | ||||
| Component: | Client | Assignee: | Susan McCourt <susan> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | ||||||
| Version: | 0.4 | ||||||
| Target Milestone: | 0.5 M1 | ||||||
| Hardware: | PC | ||||||
| OS: | Mac OS X - Carbon (unsup.) | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Wow. Wish I could say it was on purpose (bug 360996) but even if we did expose more file commands in favorites, it wouldn't be via a double chevron. There are two things to look at there. 1) why are those contributions showing up (this is related to the way we store command contributions and part of the work I want to do in bug 370014). 2) if indeed we wanted those contributions to appear, why are they causing two menus vs. one? (In reply to comment #1) > Wow. Wish I could say it was on purpose (bug 360996) but even if we did expose > more file commands in favorites, it wouldn't be via a double chevron. > > There are two things to look at there. > 1) why are those contributions showing up (this is related to the way we store > command contributions and part of the work I want to do in bug 370014). I fixed bug 370014. We now contribute what used to be called "object" contributions by specifying a contribution id that is used in rendering. This lets us pick and choose what file-level commands show up where. Having done this, and having favorites define its commands, the double chevron is gone. fixed. |
Created attachment 211734 [details] You can see two chevrons per favorite After installing the sampleCommandsPlugin and reloading the Navigator the favorites all now have two chevrons with items. Not sure this is correct.