Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 372726

Summary:	scm bundle importer must reset pages before setting selection
Product:	[Eclipse Project] PDE	Reporter:	Dani Megert <daniel_megert>
Component:	UI	Assignee:	Dani Megert <daniel_megert>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	Curtis_Windatt, daniel_megert, tomasz.zarna
Version:	3.8
Target Milestone:	3.8 M6
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Dani Megert

2012-02-28 07:29:25 EST

master

The scm bundle importer must reset its pages before setting selection, otherwise it will import all bundles/descriptions if the user didn't choose any bundle from a certain importer (type).

Test Case
1. add all necessary patches to get the EGit import working
2. start to import 1 project that is in EGit

==> after the import it prompts for the CVS password because the CVS import page still has all descriptions set.

Comment 1 Dani Megert

2012-02-28 07:43:57 EST

Fixed in master: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=0ffadbe8ed59ea26766eeba76f3a192f112762e9

Comment 2 Dani Megert

2012-02-28 09:11:05 EST

Discussed this with Tomek: the fix works, but in fact it is only needed because we wrongly set the selection upfront. A better fix is to remove my fix and also the unnecessary  call to etSelection(...).

Fixed in master: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=e8fba4748740b9643a72df38134958d0da3271ee