Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 372648

Summary:	[Mac] Go To Line's keybinding clobbers "select location bar" browser action
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Client	Assignee:	Mark Macdonald <mamacdon>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.4
Target Milestone:	3.0 M2
Hardware:	PC
OS:	Mac OS X
Whiteboard:
Bug Depends on:	372652
Bug Blocks:

Description Mark Macdonald

2012-02-27 09:55:23 EST

Firefox, Chrome

1. Open the Orion editor and give it focus
2. Press Cmd+L
3. The "Go To Line" command activates. I expected the Location bar to be selected instead.

Since this is a pretty common browser action, perhaps Go To Line should be changed to Ctrl+L.

The same problem happens on Windows with Ctrl+L, but it's not as bad since you can use Alt+D as an alternate keybinding to select the location bar.

(I'm still not sure what our policy on clobbering browser keys is -- should we allow it only if the browser action is frequently used?)

Comment 1 Mark Macdonald

2012-02-27 10:57:43 EST

(In reply to comment #0)
> (I'm still not sure what our policy on clobbering browser keys is -- should we
> allow it only if the browser action is frequently used?)

Of course this should say "allow it only if the browser action is *not* frequently used".

Comment 2 Susan McCourt

2012-02-27 11:34:11 EST

yes, we need a strategy.
I think step one is to decide whether we want a special editor mode, such as Esc+key binding.  I've moved that discussion into bug 372652

Comment 3 Mark Macdonald

2013-05-03 17:15:23 EDT

Working on a Mac today and this drove me nuts. I changed the Mac key binding for Go To Line to Ctrl+L, so Cmd+L is now left as the browser "select address bar" hotkey.

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=540af9251f7963cf9e4328d6db56a7edd9d6c89a