Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 372486

Summary: Integrate with GitHub and Gerrit review flow
Product: [ECD] Orion Reporter: Szymon Brandys <Szymon.Brandys>
Component: GitAssignee: Project Inbox <orion.git-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: john.arthorne, ken_walker, susan, tomasz.zarna
Version: 0.4   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Szymon Brandys CLA 2012-02-24 09:16:54 EST
This is similar to bug 369591, but I think it is worth of a separate bug.

As Susan wrote the workflow is something like that:

- contributor sends a pull request or link to a commit in github
- we open the commit in Orion (using Open Commit)
- if it is fine, we cherry pick the commit and push it

In our case the commit is published via GitHub. Let's say we opened the commit and want to comment on it. We can:
1) comment on Bugzilla
2) comment on GitHub using GitHub comments mechanism
If the commit was published via Gerrit, we could also 3) use Gerrit for comments

There is no easy way to comment changes while looking at them though. When you want to put a comment for a specific line, you need to switch to another page, put a comment, refer a line and then switch to the commit page.

I thought that some kind of annotations in the compare editor would be nice. Setting the annotation on the editor would store a comment on GitHub, Gerrit or Bugzilla. Or hovering on a line would show an action to add a comment. Clicking it, would open GitHub, Gerrit or Bugzilla ready to put a comment for this line. Like "Clone into Orion" case but in an opposite way.
Comment 1 Szymon Brandys CLA 2012-10-18 10:52:41 EDT
We have new review contribution tool and I do not plan to look at integration with Gerrit itself.