Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 372338

Summary:

Git repository buttons are in a different order on different browsers

Product:

[ECD] Orion

Reporter:

Max Li <maxli>

Component:

Client

Assignee:

Susan McCourt <susan>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

0.4

Target Milestone:

0.5 M1

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
screenshot	none

Description Max Li

2012-02-23 09:34:37 EST

1. Go to the Repositories page in Firefox and Chrome.
2. The buttons next to each repository (Pull, Apply Patch, Delete) are in a different order in each browser. In Firefox, the order is Pull, Apply Patch, Delete. In Chrome, it is Pull, Delete, Apply Patch.

Comment 1 Max Li

2012-02-23 09:36:06 EST

Created attachment 211491 [details]
screenshot

I've attached a screenshot

Comment 2 Szymon Brandys

2012-02-23 10:03:35 EST

Thanks Max.

Comment 3 Susan McCourt

2012-02-23 10:06:46 EST

As part of this bug we should also make sure order is consistent across sections.  For example, maybe delete is always on the right?  I'd also like to see "checkout" and "merge" separated a little, for some reason I find myself pushing merge when I mean checkout, some separation might help.

Comment 4 Susan McCourt

2012-03-02 17:08:14 EST

I fixed this in the course of touching all the git commands in bug 370014.
The problem is that all the contributions were using a position of 1000, so you ended up sorting a bunch of equal contributions and the order would be determined by the js array sort implementation.

I changed the contributions to use different positions.  In doing so, I tried to make sure that delete "X" is always last for uniformity.