Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 372233

Summary:	Do orion.page.link service implementations need an "Id" property?
Product:	[ECD] Orion	Reporter:	John Arthorne <john.arthorne>
Component:	Client	Assignee:	Project Inbox <orion.client-inbox>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.4
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description John Arthorne

2012-02-22 09:22:22 EST

I see our orion.page.link service implementations all define a property called "Id". However I can't find these Ids referenced anywhere. I wonder if this was just done out of habit because all Eclipse extensions used to define Ids? If it's not used we should consider deleting it. If we intend to use it, we should document what it is for (perhaps as a DOM id for an anchor element manifesting the link?).

Comment 1 Susan McCourt

2012-02-22 10:50:15 EST

(In reply to comment #0)
> I see our orion.page.link service implementations all define a property called
> "Id". However I can't find these Ids referenced anywhere. I wonder if this was
> just done out of habit because all Eclipse extensions used to define Ids? 

I think it's because of all our command extensions need unique ids, we had to go back and add them.  I probably just added one for completeness.

> If
> it's not used we should consider deleting it. If we intend to use it, we should
> document what it is for (perhaps as a DOM id for an anchor element manifesting
> the link?).

Not a bad idea,  I could imagine if we start adding things like rich hovers, etc. we may need to look up the extension by dom id.

Comment 2 John Arthorne

2012-02-28 16:18:29 EST

Ok leaving it alone for now.