Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 372183

Summary:	WorkbenchApplicationConfigurator should have public constructor
Product:	[RT] RAP	Reporter:	Gunnar Wagenknecht <gunnar>
Component:	Workbench	Assignee:	Project Inbox <rap-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3
Version:	1.5
Target Milestone:	1.5 M6
Hardware:	All
OS:	All
Whiteboard:

Description Gunnar Wagenknecht

2012-02-22 01:38:23 EST

I wish it would be offered as API somehow but for now I'm ok with just having the WorkbenchApplicationConfigurator constructor public. It would be also nice if the service reference can be made optional, i.e. only create and check the filter if a service reference is present.

Are you comfortable with accepting a patch that would make this API and which introduces some protected "hook" methods to allow filtering of possible contributions?

Comment 1 Ralf Sternberg

2012-02-22 07:46:44 EST

Gunnar, could you explain why the RWT-OSGi integration is not suitable for your use case?

Before you create a patch, let's discuss if there are objections to making the configurator public.

Comment 2 Gunnar Wagenknecht

2012-02-22 08:00:14 EST

(In reply to comment #1)
> Gunnar, could you explain why the RWT-OSGi integration is not suitable for your
> use case?

We provide the admin console on a separate HTTP port. Previously this was implemented by providing a separate HttpService. Technically, it's a separate Jetty server with it's own connector, session, security, etc. The only reason this was exposed as HttpService was because of the way RAP 1.4 integrates in an OSGi environment.

Now with the RWTServlet I'd like to drop the HttpService and simply hook the RWTServlet directly in Jetty.

Have a look at:
http://git.eclipse.org/c/gyrex/gyrex-admin.git/tree/bundles/org.eclipse.gyrex.admin.ui/src/org/eclipse/gyrex/admin/ui/internal/AdminUiActivator.java?id=eb543784ef44528f8f4d22501ba3f48b6b3782c1#n174 (line 174-204)

http://git.eclipse.org/c/gyrex/gyrex-admin.git/tree/bundles/org.eclipse.gyrex.admin.ui/src/org/eclipse/gyrex/admin/ui/internal/application/AdminApplicationConfigurator.java?id=eb543784ef44528f8f4d22501ba3f48b6b3782c1#n37 (line 37)

Comment 3 Ralf Sternberg

2012-02-22 10:37:26 EST

Thanks for the explanation. I made the constructor public as requested. For those additional "hooks", please attach a patch.
I'd prefer to keep the class internal anyway. If it turns out that more people are using it, we can still think about making it API.

Comment 4 Ivan Furnadjiev

2012-03-05 06:07:13 EST

(In reply to comment #3)
> I made the constructor public as requested.
Can we close this bug?

Comment 5 Gunnar Wagenknecht

2012-03-05 06:25:26 EST

IMHO Yes.

Comment 6 Ivan Furnadjiev

2012-03-05 06:30:43 EST

(In reply to comment #5)
> IMHO Yes.