Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 372166

Summary: [Safari] Find/Replace parameter area not layout properly
Product: [ECD] Orion Reporter: Silenio Quarti <Silenio_Quarti>
Component: EditorAssignee: Project Inbox <orion.editor-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ken_walker, Mike_Wilson
Version: 0.4   
Target Milestone: 0.4 RC2   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
screenshoot of the problem none

Description Silenio Quarti CLA 2012-02-21 16:38:42 EST
Created attachment 211370 [details]
screenshoot of the problem

On Chrome/Safari, after typing Cmd+F in the editor, the parameter collector area is clipped on the bottom. I will attach a screenshot.

The initially shows up properly (for half a second) and then it seems that the content grows and pushes the bottom border under the editor.

If I resize the browser window, the layout gets fixed.

The problem does not happen on Chrome/Windows.
Comment 1 Ken Walker CLA 2012-02-21 16:55:23 EST
I think this is fixed in Bug 370481

I have side by each before and with change since I was checking that bug and without the changes I see the same thing, and after it is gone.
Comment 2 Silenio Quarti CLA 2012-02-21 17:42:40 EST
I cannot reproduce the problem with latest orion.eclipse.org in Chrome, but it still happens in Safari.
Comment 3 Susan McCourt CLA 2012-02-21 19:24:30 EST
(In reply to comment #2)
> I cannot reproduce the problem with latest orion.eclipse.org in Chrome, but it
> still happens in Safari.

I think this should go away when bug 370481 is in the build.
The problem is that the icons in the slideout commands are not defined in CSS classes, but with image files.  So the commands get rendered and the download of the icon gets in a race with the layout of the slideout.  Depending on download speed, etc...you may or may not see the problem.

Mark noticed this morning that it happened consistently in a self hosted workspace (where there is no cache and the icon is downloaded everytime the slideout is opened) and only about 10% of the time on orion.eclipse.org, where everything is faster and you have a cache.

Bug 370481 uses an image class instead and I noticed while testing that bug that you may see a lag in the icons appearing, but the space is properly reserved for them, and this bug disappears.

So I think we can close this in the next build.
Comment 4 Susan McCourt CLA 2012-02-22 10:55:04 EST
Silenio, can you confirm that you no longer see this problem in the current build?  If so, you can mark this a dup 370481 (not truly a dup but that fix addressed the issue).
Comment 5 Silenio Quarti CLA 2012-02-22 10:57:09 EST
Yes, the problem is gone from Chrome and Safari.
Comment 6 Susan McCourt CLA 2012-02-22 12:43:55 EST
fixed with the fix for bug 370481