Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 372053

Summary:	common headings, parameter slideouts, positioning
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Szymon.Brandys
Version:	0.4
Target Milestone:	0.5 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2012-02-20 14:05:17 EST

We currently have multiple places where slideouts and headings are created.
1.  slideouts are in the toolbar template in commonHTMLFragments
2.  a slightly different template is used in mUtil.createPaneHeading.  This also generates section headings for pages like git status and favorites
3.  repository and commit pages generate their own headings and slideout templates

Layout changes for slideouts were risky at the end of 0.4 release because of the duplicated code, and slightly different CSS surrounding these headings.  Once we converge the code, we have some layout fixing to do:

- position the parameter slideout so it aligns horizontally with the toolbar or section header where it appears.
- dismiss controls should be on the right.

Comment 1 Susan McCourt

2012-05-15 17:07:47 EDT

we now are using common slideout code in the Section class, so the efforts can be focused on that one.  I'll take a look at the styling and make sure it's up to snuff.

Comment 2 Susan McCourt

2012-05-16 19:43:25 EDT

I fixed the dismiss controls and cleaned up the layout a bit.
I also changed section.js so that it uses the exact same HTML fragment as the toolbar.  Now we can fix the styling and content issues in one place.

Leaving this bug open for now because there is still some work to do on the dismiss controls:

- the right hand close button needs a permanent border similar to what Anton did for the command buttons.  It is shifting a bit on hover, also, so if bordering doesn't fix this, I will clean it up.
- vertical alignment is not very nice between "Submit" and "X"

Comment 3 Susan McCourt

2012-05-21 16:16:52 EDT

The slideouts seemed to have shifted again since I cleaned up the layout.  The parameters were all shifted downward but the submit buttons were not.  The problem was that some margins had been added to layoutLeft and not right layoutRight.  I removed the margins from layoutLeft.

The problem with the shifting close box was that a border-none had been added to the spriting css class, so the transparent border added to the button (to prevent hover shift when a border gets added) was gone, causing the entire button to shift on hover.  I removed the border from that class.

Fixed with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=45b3990df0a09974bc08d499814aebcb36e81e04