Bugzilla – Full Text Bug Listing
| Summary: | Changing font colour to White means never seeing your line numbers | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Ken Walker <ken_walker> |
| Component: | Client | Assignee: | Silenio Quarti <Silenio_Quarti> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | antonm, eclipse.felipe, Mike_Wilson, Silenio_Quarti |
| Version: | 0.4 | Flags: | eclipse.felipe:
review+
ken_walker: review+ |
| Target Milestone: | 0.3 RC3 | ||
| Hardware: | PC | ||
| OS: | Mac OS X - Carbon (unsup.) | ||
| Whiteboard: | |||
|
Description
Ken Walker
Here is a fix (branch=bug371937): http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?h=bug371937&id=ca592f60f56585e4e72de02c613dd3c724145eac This fix makes the background property affect the rulers as well. I believe this is the safest to do for 0.4. After 0.4, you should add more entries in the settings page to control those colours independently. Other colour settings that should be in the page: - the highlight current line colour - ruler color/background - tags/html markup in js doc comments safe fix. Made a new bug to track this request. https://bugs.eclipse.org/bugs/show_bug.cgi?id=372139 (In reply to comment #1) > Here is a fix (branch=bug371937): > > http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?h=bug371937&id=ca592f60f56585e4e72de02c613dd3c724145eac > > This fix makes the background property affect the rulers as well. I believe > this is the safest to do for 0.4. After 0.4, you should add more entries in > the settings page to control those colours independently. > > Other colour settings that should be in the page: > > - the highlight current line colour > - ruler color/background > - tags/html markup in js doc comments As project lead I +1 this for RC3 |