Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 371912

Summary:

layout of "related pages" is off, other heading layout tweaks

Product:

[ECD] Orion

Reporter:

Susan McCourt <susan>

Component:

Doc

Assignee:

Susan McCourt <susan>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

ken_walker, mamacdon

Version:

0.4

Flags:

mamacdon: review+
ken_walker: review+

Target Milestone:

0.4 RC3

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Replace layout still a bit off?	none

Description Susan McCourt

2012-02-17 12:36:22 EST

RC2 candidate.
When the "related pages" menu comes in, it disturbs the vertical layout of the star and search box.  I'd like to took at tweaking the CSS for this in RC3. It looks sloppy.

I'd also like to try to line up the breadcrumb with the page title, the indent is accidental.  This is less critical.

Comment 1 Susan McCourt

2012-02-20 13:57:10 EST

The remote branch
origin/css04RC3
contains some CSS and layout changes that I propose to make for 0.4 RC3.

The changes address three bugs, as well as some styling/color issues Linda noticed while reviewing the implementation.
this one (layout of related pages)
bug 370841 - layout and appearance of slideout
bug 371366 - cursor on close button

Changes:
========
commands.css - fix command button colors so toolbars don't appear gray, fix the "temporary sprites" so that images are centered and don't have extra margins.  This helps to fix the alignment of the favorite star in the banner.  Add pointer to close sprite.
========
ide.css - add class "clear" to get layout blocks without margins, add a class for a menu in a slideout (used by find/replace), change font/layout/margins/hover appearance for slideout dismiss buttons, fix toolbar colors to not look gray, add margin to searchbox to align better with related pages.
========
commonHTMLFragments.js - use "clear" instead of "layoutBlock" to prevent double indent of title area
========
textSearcher.js - use "parametersMenu" instead of "commandImage" for options menu
========
parameterCollectors.js - remove "spacer" spans since CSS provides margins, switch to "close" icon instead of "delete", use text instead of icons for "More" and "Submit"

Comment 2 Susan McCourt

2012-02-20 13:57:43 EST

Ken, Simon:  ok to fix?
Mark: can you review?

Comment 3 Susan McCourt

2012-02-21 11:40:09 EST

to review effect of changes, look at:
- layout of related pages, star, searchbox
- alignment on left of page title/breadcrumb
- find/replace slideout

Comment 4 Ken Walker

2012-02-21 12:52:18 EST

Created attachment 211350 [details]
Replace layout still a bit off?

Comment 5 Ken Walker

2012-02-21 12:57:13 EST

Checked before and after and code, looks good. As a project lead I +1 these for RC3.

My attachment is something else and will be resolved later.

Comment 6 Susan McCourt

2012-02-21 13:04:27 EST

(In reply to comment #4)
> Created attachment 211350 [details]
> Replace layout still a bit off?

I opened bug 372146 to capture the general problem.  The find and replace slideouts are using a mix of generated content and command framework, so different styling is being mixed and matched.  The long term solution is to fix some of the span nesting, etc. in these slideouts, or else support them officially.

Comment 7 Mark Macdonald

2012-02-21 13:32:20 EST

+1 here.

Comment 8 Susan McCourt

2012-02-21 13:36:06 EST

pushed fix.
578e912f056d78f9b3193bd466bb0d35723d5295