Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 371882

Summary:

Git Log get cleared after a failed Push

Product:

[ECD] Orion

Reporter:

Tomasz Zarna <tomasz.zarna>

Component:

Git

Assignee:

Szymon Brandys <Szymon.Brandys>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

ken_walker, malgorzata.tomczyk, susan, Szymon.Brandys

Version:

unspecified

Flags:

malgorzata.tomczyk: review+
ken_walker: review+

Target Milestone:

0.4 RC3

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Fix v1	none

Description Tomasz Zarna

2012-02-17 08:14:57 EST

Steps:
1. Setup a repo so you have an outgoing commit which you know cannot be pushed, is not FF
2. Go to Git Log page
3. Press "Push All"

Operation fails saying "REJECTED_NONFASTFORWARD", good. At the same time, Git Log is cleared, shows no commits. They show up again after refreshing the page.

Comment 1 Tomasz Zarna

2012-02-17 08:15:52 EST

It happened on orion.eclipse.org today, while investigating bug 371881.

Comment 2 Malgorzata Janczarska

2012-02-21 10:07:52 EST

I had the same problem with "UP_TO_DATE" status on Push.

Comment 3 Susan McCourt

2012-02-21 12:12:47 EST

changed milestone (assuming it's for 0.4RC3)

Comment 4 Malgorzata Janczarska

2012-02-22 08:02:00 EST

I discovered that it's probably something with push task, because if push doesn't run as task, but in one request, everything works fine.

Comment 5 Szymon Brandys

2012-02-22 12:10:52 EST

Created attachment 211430 [details]
Fix v1

Comment 6 Szymon Brandys

2012-02-22 12:17:24 EST

The problem was that we called changedItem on git-log page and this cleared the page.

There is another problem in Git Push API as Gosia mentioned in comment 4. However this is not the cause of this bug. I'll raise a separate bug for that (for .5).

Comment 7 Ken Walker

2012-02-22 12:51:32 EST

Have tested before and after.

As a project lead I +1 this for RC3

Comment 8 Szymon Brandys

2012-02-22 13:06:34 EST

Fixed with 7d6771daf9caa1f7f0e30ff5dddddd5291adbf15.