Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 371492

Summary: [Chrome] Weird outline around first menu item
Product: [ECD] Orion Reporter: Mark Macdonald <mamacdon>
Component: ClientAssignee: Max Li <maxli>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: maxli
Version: 0.4   
Target Milestone: 0.5 M1   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
screenshot none

Description Mark Macdonald CLA 2012-02-14 09:09:32 EST
Created attachment 210975 [details]
screenshot

Using Chrome 18.0.1025.11 (WebKit 535.19) on orion.eclipse.org

I just got auto-upgraded to a recent beta of Chrome. In this version, every dropdown menu has an orange outline around the first menu item (see screenshot). The outline remains on the first item even as you hover or keyboard navigate through the other items, so misleads you as to where the focus actually is.
Comment 1 Susan McCourt CLA 2012-02-14 10:51:00 EST
actually I think it's telling you where the (keyboard) focus is.  If you use down arrow on the menu, does it move?

It is pretty ugly but I suspect it's just "new and improved showing of keyboard focus."
Comment 2 Mark Macdonald CLA 2012-02-14 11:03:32 EST
(In reply to comment #1)
> actually I think it's telling you where the (keyboard) focus is.  If you use
> down arrow on the menu, does it move?

No, it stays at the top... The arrow keys don't affect it. 

I guess the outline has something to do with focus, but it's not following the dijit focus.
Comment 3 Susan McCourt CLA 2012-02-14 11:11:08 EST
(In reply to comment #2)
> (In reply to comment #1)
> > actually I think it's telling you where the (keyboard) focus is.  If you use
> > down arrow on the menu, does it move?
> 
> No, it stays at the top... The arrow keys don't affect it. 
> 
> I guess the outline has something to do with focus, but it's not following the
> dijit focus.

sigh.  As if that missing border (bug 361546) weren't enough to make menus look bad on Chrome.
Comment 4 Max Li CLA 2012-04-03 14:40:35 EDT
I encountered a similar problem while make the settings page accessible, so I figured I'd fix it here too. I removed the outline since there's already an indication of focus on the menu.

Fixed with

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e517925faffebbf0143916e8c6724594cdb271b3
Comment 5 Susan McCourt CLA 2012-04-03 15:22:11 EDT
(In reply to comment #4)
> I encountered a similar problem while make the settings page accessible, so I
> figured I'd fix it here too. I removed the outline since there's already an
> indication of focus on the menu.
thanks, Max!