Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 371482

Summary:

Editing values on settings on settings.html and config entries on git-repository.html

Product:

[ECD] Orion

Reporter:

Szymon Brandys <Szymon.Brandys>

Component:

Client

Assignee:

Project Inbox <orion.client-inbox>

Status:

RESOLVED WONTFIX

QA Contact:

Severity:

normal

Priority:

CC:

antonm, malgorzata.tomczyk, simon_kaegi, susan

Version:

0.4

Target Milestone:

---

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
git-repository.html - 'pen' icon opens a slideout to collect the new value	none
git-repository.html - 'pen' icon replaces the area showing key/value with an editor with Ok/Cancel actions	none
settings.js - some ideas	none

Description Szymon Brandys

2012-02-14 07:10:00 EST

On settings.html we can change font settings and colors. I got used to pages with "Apply/Save changes" button. When I click it, I know that all changes are applied. On our page I'm not sure if something was really changed. To verify, I have to open the editor or refresh the settings page. Maybe a notification saying "Color was changed" (similar to "Plug-ins reloaded") would be helpful.
The reason why the problem became apparent to me is a problem with the editor that I had today. I couldn't open newly created files (can't reproduce it now). The editor ended up is some weird state with no font/color settings applied and showing "Fetching all the time". I was able to edit the file though, but settings were still not applied. At first I thought that changes were just not saved and I started looking for "Apply" button on settings.html.

On git-repository.html we have a list of conf entries. To change them you have to click "pen" icon, provide the new value, click Enter. There is also no notification, but you can at least see the entry updated in the config list.

So it seems there are at least three ways of changing settings, configurations.
1) List of fields with one "Apply changes" for all
2) Just a list where changes are applied immediately (like on settings.html)
3) List of values with "Edit action". "Edit" opens some UI (e.g. slideout) with "Ok" button. Clicking it means the change is applied.

I think there is a place for unification here.

I like approach 3). I'll attach some mockups how both settings.html and git-repository.html could look like.

Comment 1 Szymon Brandys

2012-02-14 07:15:42 EST

Created attachment 210968 [details]
git-repository.html - 'pen' icon opens a slideout to collect the new value

git-repository.html - 'pen' icon opens a slideout to collect the new value
This is how it looks now.

Comment 2 Szymon Brandys

2012-02-14 07:23:01 EST

Created attachment 210969 [details]
git-repository.html - 'pen' icon replaces the area showing key/value with an editor with Ok/Cancel actions

git-repository.html - 'pen' icon replaces the area showing key/value with an editor with Ok/Cancel actions

Comment 3 Szymon Brandys

2012-02-14 07:34:36 EST

Created attachment 210970 [details]
settings.js - some ideas

Some ideas for settings.js
1) By default you see a preview of font/color settings and "Edit" action next to it
2) Clicking "Edit" will replace the preview with an edit area
3) The preview string changes when you change values in the edit area
4) To apply new values just click "X"

Comment 4 Susan McCourt

2012-02-14 10:46:53 EST

interesting.  That second screenshot is a bit how we do rename today, except we don't have the buttons for ok/cancel (which makes it hard on a tablet that has no keyboard).  I like the idea of refining the "edit in place" with the affordances that the slideout has...

maybe mUtil.getUserText should provide this (it is the utility that pops up edits on a dom node)

Comment 5 Simon Kaegi

2012-05-28 12:38:37 EDT

Szymnon, I'm not sure if this is something we still want to target for 0.5 but please take a look.

Comment 6 John Arthorne

2015-05-05 14:48:33 EDT

Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:

https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html