Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 371323

Summary: [regression] all comments are shown as incoming
Product: z_Archived Reporter: Steffen Pingel <steffen.pingel>
Component: MylynAssignee: Steffen Pingel <steffen.pingel>
Status: RESOLVED FIXED QA Contact:
Severity: critical    
Priority: P3    
Version: unspecified   
Target Milestone: 3.7   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 349620    
Attachments:
Description Flags
mylyn/context/zip none

Description Steffen Pingel CLA 2012-02-12 06:50:32 EST 
As a side-effect of the reverted change for bug 349620 all task comments are shown as incoming. This is due to a different value mapping for task comments:

Mylyn 3.6: 
  comment ID -> comment attribute value
Mylyn 3.7 after 1ff7e0bd7ef8653133985473b4eef38a7ae3bbee and before 9f99269112887b9003a6938eb5b59c1eb44f969b
  comment number -> comment attribute value
Mylyn 3.7 after 9f99269112887b9003a6938eb5b59c1eb44f969b:
  comment ID -> comment attribute value

Additionally Bugzilla changed the attribute value that is used for ID. In Mylyn 3.6 the comment number was set as the attribute value whereas now Bugzilla is using the actual comment ID.
Comment 1 Steffen Pingel CLA 2012-02-12 07:29:10 EST 
I have pushed a potential fix to this review: http://review.mylyn.org/#change,280
Comment 2 Steffen Pingel CLA 2012-02-12 07:34:51 EST 
I have pushed the fix to master and kicked off a new build.
Comment 3 Steffen Pingel CLA 2012-02-12 07:34:54 EST 
Created attachment 210892 [details]
mylyn/context/zip