Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 371318

Summary: plugins page gets weird scrollbars after plug-in install.
Product: [ECD] Orion Reporter: Susan McCourt <susan>
Component: ClientAssignee: Anton McConville <antonm>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: 0.4 RC2   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
screenshot none

Description Susan McCourt CLA 2012-02-11 21:57:59 EST 
I tried Mark's new "Get Plugins" link and installed the Esprima outline plugin.  When I got back to the plugins page and hit "Enter" in the slideout, I got a progress message for install (good). But when it finished installing, suddenly all of the plugin entries grew horizontal scrollbars.

At that point I had to reload the page to get it looking again.

I think we should fix this because the "Get Plugins" flow is a very cool demonstration of the power of our extensions and it'd be nice not to have a little glitch in the end.

This was on Chrome.
Comment 1 Susan McCourt CLA 2012-02-11 21:59:26 EST 
Created attachment 210891 [details]
screenshot
Comment 2 Anton McConville CLA 2012-02-13 09:40:32 EST 
(In reply to comment #1)
> Created attachment 210891 [details]
> screenshot

I saw something similar when working with it on Friday night. Actually I've moved the plugin entries ( each line in the list ) to be a Dojo widgit now, and I think that it also improves things with the initialization and sizing of each row - will run some more tests this morning, and hopefully ask you to commit it for me later in the day.
Comment 4 Susan McCourt CLA 2012-02-13 13:10:47 EST 
Verified that the problem is fixed.
From a risk assessment point of view, it's hard to verify because lots of stuff has moved around (this was a refactoring intended for the future).

If this page had been unchanged for some time, I'd be inclined to reject this commit and ask for a more surgical fix.  However, the code just landed late Thursday and only has a day (if that) testing on it.  So I think we'd be better off taking the refactoring and getting folks banging on it now.

I tried install (from slideout), reload all, reload, remove, etc. and everything seems in order.  

So I'm OK to commit this once we get the all clear for releasing into RC2.
Comment 5 Susan McCourt CLA 2012-02-13 15:21:03 EST 
all clear.  pushed.