Bugzilla – Full Text Bug Listing
| Summary: | Use SWTChart API for charting | ||
|---|---|---|---|
| Product: | [Tools] Linux Tools | Reporter: | Roland Grunberg <rgrunber> |
| Component: | Project | Assignee: | Roland Grunberg <rgrunber> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | anithra, jerome.correnoz, lilia.ghachem, obusatto, overholt, wainersm, xraynaud |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Bug Depends on: | 373552 | ||
| Bug Blocks: | |||
Adding interested parties to CC. Some information I have already sent to the mailing list ------------- Systemtap and massif uses BIRT API directly. Gprof and gcov relies on org.eclipse.linuxtools.dataviewers.charts, that in turn uses BIRT API. BIRT charts being used: * Systemtap (some charts are not working) Area Chart Bar Graph Line Graph Meter Chart Pie Chart Scatter Graph * Massif exports chart as svg scatter chart * gprof and gcov bar graph (horizontal and vertical) pie chart (3d) export chart as jpeg As an update, the work has been done for Massif (feature/valgrind/no-birt) is now merged into master. As for gprof/gcov, the only functionality that will not be possible is the pie chart. SWTChart currently has no API for generating pie charts, but perhaps this could be proposed in the future. I've started having the dataviewers plugin hook into org.swtchart for charting. I can see that the dataviewers also had some functionality to import/export a chart as XML. It goes without saying that SWTChart doesn't have this capability, but the .gmon output file can always serve as a way of storing the chart data in a "lossless" sense. (In reply to comment #3) > As an update, the work has been done for Massif (feature/valgrind/no-birt) is > now merged into master. Great! I will try to test it right away. > > As for gprof/gcov, the only functionality that will not be possible is the pie > chart. SWTChart currently has no API for generating pie charts, but perhaps > this could be proposed in the future. so for now gprof/gcov will still be birt-dependent? or do you plan to work on the SWTChart as well? In this case it'd be an all or nothing switch. The exporting/importing XML was probably designed to work with the BIRT charting framework, so I don't think we'd be able to use that functionality at all if we switched to SWTChart. The importing chart XML is currently disabled. (In reply to comment #6) > In this case it'd be an all or nothing switch. The exporting/importing XML was > probably designed to work with the BIRT charting framework, so I don't think > we'd be able to use that functionality at all if we switched to SWTChart. The > importing chart XML is currently disabled. Does anyone use that? As you said it is possible to recreate the chart every time you need using the .gmon file. Saving the xml only makes sense to me if someone is parsing that in any external project. But I don't think it is the case. (In reply to comment #7) > (In reply to comment #6) > > In this case it'd be an all or nothing switch. The exporting/importing XML was > > probably designed to work with the BIRT charting framework, so I don't think > > we'd be able to use that functionality at all if we switched to SWTChart. The > > importing chart XML is currently disabled. > > Does anyone use that? As you said it is possible to recreate the chart every > time you need using the .gmon file. Saving the xml only makes sense to me if > someone is parsing that in any external project. But I don't think it is the > case. Does SwtChart support export as an image file? That is a feature really useful that I'll miss. Agreed (comment 7). Though given that we'd be removing functionality I don't mind hearing other people's points of view on this. SWTChart doesn't export as an image file from what I can see but there is support in SWT for this. Basically converting a Composite to an image. In Massif I exported the chart as a PNG (ChartPNG.java:35 , renderPNG()). CC'ing Lilia from ST to be sure she's aware (althought perhaps Jerome is already aware enough for ST :) ). I've set up a remote branch (feature/dataviewers/no-birt) to track progress. I've implemented bar chart rendering, and saving as an image file. This should be most of the work. feature/dataviewers/no-birt has been merged into master. See 99cfe57c1eb03e84062b1b15c8606f4425c7f9df. Resolving as fixed. |
It seems that o.e.l.{systemtap.ui.graphingapi.ui,dataviewers.charts} all use BIRT for charting. With the recent work that has switched Valgrind Massif over to using SWTChart (branch feature/valgrind/no-birt), I think we can definitely do the same for these other plugins. I'm more than willing to do this work.