Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 371230

Summary:

[FF] The 'Clone into' button on GitHub just says "Clone into"

Product:

[ECD] Orion

Reporter:

Szymon Brandys <Szymon.Brandys>

Component:

Git

Assignee:

Tomasz Zarna <tomasz.zarna>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

ken_walker

Version:

0.4

Flags:

Szymon.Brandys: review+
ken_walker: review+

Target Milestone:

0.4 RC3

Hardware:

OS:

Windows 7

Whiteboard:

firefox

Bug Depends on:

Bug Blocks:

372197

Attachments:

Description	Flags
Fix v01	none
mylyn/context/zip	none

Description Szymon Brandys

2012-02-10 08:39:31 EST

On Chrome it says "Clone into Orion" where Orion is an icon. On FF it is just "Clone into". The easiest fix would be to just replace the icon with text. But the icon looks cool though.

Comment 1 Tomasz Zarna

2012-02-13 04:40:00 EST

A perfect .4RC3 candidate.

Comment 2 Tomasz Zarna

2012-02-21 11:05:02 EST

Created attachment 211338 [details]
Fix v01

Using dot operator instead of subscript notation seems to fix the FF compatibility issue.

Comment 3 Tomasz Zarna

2012-02-21 11:05:05 EST

Created attachment 211339 [details]
mylyn/context/zip

Comment 4 Ken Walker

2012-02-21 14:40:14 EST

As a project lead I +1 this for RC3.

The icon highlighted looks a bit off but it's better than what was there.  Before it was unclear on what that button meant.

Comment 5 Szymon Brandys

2012-02-22 05:13:58 EST

(In reply to comment #4)
> The icon highlighted looks a bit off but it's better than what was there.
> Before it was unclear on what that button meant.

The request for better icon(s) is bug 372197.

Comment 6 Tomasz Zarna

2012-02-22 05:25:02 EST

Thanks guys, fixed with dc6f4018820373a7c8a566591c6c9cfdaa8a4c57