Bugzilla – Full Text Bug Listing
| Summary: | New project is not moved to the correct working set and a corrupted project is created | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Sebastien Pennec <sebastien.pennec> | ||||
| Component: | m2e | Assignee: | Fred Bricon <fbricon> | ||||
| Status: | CLOSED FIXED | QA Contact: | |||||
| Severity: | major | ||||||
| Priority: | P3 | CC: | fbricon, igor, sebastien.pennec | ||||
| Version: | unspecified | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Sebastien Pennec
This also happens with the current milestone, version 1.1.0.20120130-2016. I suspect there is no reason this bug could not be observed on any platform. Given this bug can actually create a corrupted project, the importance should be more than "normal". (In reply to comment #3) > Given this bug can actually create a corrupted project, the importance should > be more than "normal". m2e dev team does not have immediate plans to work on this issue unless a quality patch is provided. And, quite honestly, I don't see this to be a critical issue -- just use unique artifact ids and move on. It's not just about using unique artifact IDS... If you use the archetype functionality of Maven to build a multi-module project, which is not uncommon, the dialog asks for one actifactID and the maven archetype uses it to create all the modules. At this time, the plug in either does just a part of the job, by only moving some of the modules, or does a very bad job by moving nothing and creating a corrupted project. I don't see how using a unique artifact ID would fix the problem. (In reply to comment #5) > > I don't see how using a unique artifact ID would fix the problem. If artifact id provided in the dialog does not match anything created by the archetype, everything should work as expected. In any case, if you think this is important, please submit a quality patch and we'll have a look. >> If artifact id provided in the dialog does not match anything created by the
archetype, everything should work as expected.
It does not. See the steps to reproduce the problem.
Anyway I'm surprised you don't consider creating a corrupted project a problem bad enough to fix that. We obviously don't have the same idea of what is "first-class Apache Maven support in the Eclipse IDE".
(In reply to comment #7) > >> If artifact id provided in the dialog does not match anything created by the > archetype, everything should work as expected. > > It does not. See the steps to reproduce the problem. > > Anyway I'm surprised you don't consider creating a corrupted project a problem > bad enough to fix that. We obviously don't have the same idea of what is > "first-class Apache Maven support in the Eclipse IDE". Provide a quality patch and I'll review and apply it. m2e development environment setup is documented in http://wiki.eclipse.org/M2E_Development_Environment Created attachment 212062 [details]
Patch fixing the issue
The fix is fairly trivial but requires to change the public API for IProjectConfigurationManager from :
void createArchetypeProject(...)
to
List<IProject> createArchetypeProject(...)
I don't think that can be a problem, but since that's public API change, I prefer Igor's greenlight before pushing any changes.
(In reply to comment #9) > Created attachment 212062 [details] > Patch fixing the issue > > The fix is fairly trivial but requires to change the public API for > IProjectConfigurationManager from : > void createArchetypeProject(...) > to > List<IProject> createArchetypeProject(...) > > I don't think that can be a problem, but since that's public API change, I > prefer Igor's greenlight before pushing any changes. Hi Fred, Thanks for making this patch! Have you had any contacts with Igor regarding the public API change? Committed fix in http://git.eclipse.org/c/m2e/m2e-core.git/commit/?id=7e5cbde3cd2b93ff2f1748871207987404b82901 I still need to add some regression tests. Igor, we're short of Target Milestones (M6+1 ...) Sébastien, you can test a dev build from https://repository.sonatype.org/content/sites/forge-sites/m2e/1.1.0/N/LATEST/ (In reply to comment #12) > Sébastien, > > you can test a dev build from > https://repository.sonatype.org/content/sites/forge-sites/m2e/1.1.0/N/LATEST/ Hello Fred, I'll test this build asap and post a feedback here. Thanks! (In reply to comment #12) > Sébastien, > > you can test a dev build from > https://repository.sonatype.org/content/sites/forge-sites/m2e/1.1.0/N/LATEST/ Hello Fred, I've tried with the specified build, on a brand new Eclipse installation and it works great, thanks! Hello, Do you have a target milestone for this bug? I guess that it has not made it into the 1.1 M6 or has it? The fix will be available in the next Milestone release. I can't add target milestones to the list (or if I can, don't know how). Need Igor's über powers. apparently fixed long time ago |