Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 371077

Summary: Wrong feature.properties encoding with license-feature
Product: [Eclipse Project] PDE Reporter: Carsten Reckord <reckord>
Component: BuildAssignee: pde-build-inbox <pde-build-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3    
Version: 3.7   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description Carsten Reckord CLA 2012-02-09 08:36:58 EST 
The copy mechanism for the license-feature property in LicenseReplaceTask does not copy the feature.properties correctly. It reads and writes character streams with default encoding (usually UTF-8), while Java Properties files are encoded in ISO-8859-1 (see e.g. Properties.load(...) JavaDoc). 

This causes encoding problems with non-ASCII characters from a properly ISO encoded source feature.properties, which will be broken in the copied result. Encoding the source file in UTF-8 will result in a clean copy, but breaks whenever the properties are read (e.g. showing the feature license during install).

LicenseReplaceTask should either copy the bytestream as-is, using FileInput/OutputStreams and byte[], or explicitly use the correct ISO-8859-1 encoding with a InputStreamReader/OutputStreamWriter pair.
Comment 1 Lars Vogel CLA 2018-12-03 09:10:37 EST 
Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. 

Please reopen, if you plan to provide a fix.
Comment 2 Lars Vogel CLA 2018-12-03 09:13:30 EST 
Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. 

Please reopen, if you plan to provide a fix.