Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 371021

Summary: Incorrect validation of resource across web projects
Product: [WebTools] WTP Source Editing Reporter: Nick Sandonato <nsand.dev>
Component: wst.htmlAssignee: Nick Sandonato <nsand.dev>
Status: RESOLVED FIXED QA Contact: Nick Sandonato <nsand.dev>
Severity: normal    
Priority: P3 CC: cbridgha, neil.hauge, raghunathan.srinivasan, thatnitind
Version: 3.3.2Flags: nsand.dev: pmc_approved? (david_williams)
raghunathan.srinivasan: pmc_approved+
nsand.dev: pmc_approved? (naci.dai)
nsand.dev: pmc_approved? (deboer)
neil.hauge: pmc_approved+
nsand.dev: pmc_approved? (kaloyan)
cbridgha: pmc_approved+
thatnitind: review+
Target Milestone: 3.3.2   
Hardware: All   
OS: All   
Whiteboard: PMC_approved
Attachments:
Description Flags
patch none

Description Nick Sandonato CLA 2012-02-08 17:39:42 EST 
Introduced by bug 367856, resources referenced by an HTML file are being incorrectly flagged as missing when in another web project. This patch corrects the problem.
Comment 1 Nick Sandonato CLA 2012-02-08 17:44:06 EST 
Created attachment 210761 [details]
patch
Comment 2 Nick Sandonato CLA 2012-02-08 21:19:19 EST 
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such.

This is a slight regression in that false positive validation markers are generated. Additionally, the original patch inadvertently introduced a new UI component on the HTML validation page.

* Is there a work-around? If so, why do you believe the work-around is insufficient?
No

* How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added?

Ad hoc testing and existing unit tests have been run.

* Give a brief technical overview. Who has reviewed this fix?
The fix removes the validation component of referenced components, which was a bi-product of the actual intended fix to revalidate html files when dependent resources changed. Also, the UI component of the validation preference page was removed. Nitin has reviewed this fix.

* What is the risk associated with this fix?
Very little
Comment 3 Chuck Bridgham CLA 2012-02-09 08:47:59 EST 
This fix looks safe, although I hope the existing junit tests have been tweaked to catch this case.
Comment 4 Nick Sandonato CLA 2012-02-10 13:59:02 EST 
Code was released in yesterday after the PMC's approval.