Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 371005

Summary: [client][status] Error after I commit on a local branch
Product: [ECD] Orion Reporter: Mark Macdonald <mamacdon>
Component: GitAssignee: libing wang <libingw>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: libingw, malgorzata.tomczyk, tomasz.zarna
Version: 0.4Flags: libingw: review?
Target Milestone: 0.4 RC2   
Hardware: PC   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch file none

Description Mark Macdonald CLA 2012-02-08 15:59:17 EST
I20120207-2230 @ orion.eclipse.org

1. I am on the git-status page for a folder in my repo. My active branch is local-only (not pushed). 
2. There's 1 change I want to commit.
3. Click the Stage icon beside the commit.
4. Type a commit message, click Commit.
5. I see "Loading status..." but the page never refreshes. The console shows an error.

stack trace:
> d.empty  html.js:1591
> dojo.place  html.js:285
> orion.GitLogTableRenderer.GitLogTableRenderer.modifyHeader  git-status-table.js:532
> orion.GitStatusController.GitStatusController._initTitleBar  git-status-table.js:765
> orion.GitStatusController.GitStatusController._processCloneInfo git-status-table.js:739
> orion.GitStatusController.GitStatusController._getCloneInfo.gitService.getGitClone.gitService.getGitBranch.then.gitService.GitRemote.then.setUserEmailAndProcess  git-status-table.js:795
> ...

The DOM node "gitRemote_header" does not exist, so dojo.empty() blows up.
Comment 1 Susan McCourt CLA 2012-02-09 10:18:10 EST
Libing, I may have caused this when I changed git status to use common header/toolbar/slideout generation (mUtil.createPaneHeading).  I tried to preserve all of your old id's but this sounds like I did not.  Ping me if I need to get involved.
Comment 2 libing wang CLA 2012-02-14 11:56:19 EST
Created attachment 210984 [details]
Patch file

Mark helped reviewing the change
Comment 3 Mark Macdonald CLA 2012-02-14 11:58:43 EST
reviewed