Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 370981

Summary: New filter rule for target runtime in validator extension point is not working
Product: [WebTools] WTP Common Tools Reporter: Rosendo Martinez <rosendo>
Component: wst.validationAssignee: Rosendo Martinez <rosendo>
Status: RESOLVED FIXED QA Contact: Chuck Bridgham <cbridgha>
Severity: normal    
Priority: P3 CC: ccc, shr31223
Version: 3.2.5Flags: cbridgha: review+
Target Milestone: 3.2.5 P   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Proposed R3_2_5_patches patch none

Description Rosendo Martinez CLA 2012-02-08 12:13:28 EST
Build Identifier: 

Bug to backport fix to WTP 3.2.5P


Adding an exclusion group using the target runtime,  the new target runtime
rule is not accepted by the validation framework. An error in the log is shown:

java.lang.IllegalStateException: IWAE0102E An invalid filter rule has been
encountered. Contributing plug-in: element name: targetRuntime
    at
org.eclipse.wst.validation.internal.ValidatorExtensionReader.processRule(ValidatorExtensionReader.java:321)
    at
org.eclipse.wst.validation.internal.ValidatorExtensionReader.createFilterGroup(ValidatorExtensionReader.java:296)
    at
org.eclipse.wst.validation.internal.ValidatorExtensionReader.processIncludeAndExcludeElement(ValidatorExtensionReader.java:270)
    at
org.eclipse.wst.validation.internal.ValidatorExtensionReader.processValidator(ValidatorExtensionReader.java:177)
    at
org.eclipse.wst.validation.internal.ValidatorExtensionReader.process(ValidatorExtensionReader.java:65)
    at
org.eclipse.wst.validation.internal.ExtensionValidators.<init>(ExtensionValidators.java:43)
    at
org.eclipse.wst.validation.internal.ExtensionValidators.instance(ExtensionValidators.java:36)
    at
org.eclipse.wst.validation.internal.ValManager.getV2Validators(ValManager.java:345)
    at
org.eclipse.wst.validation.internal.ValManager.getValidatorsNotCached(ValManager.java:221)
    at
org.eclipse.wst.validation.internal.ValManager.access$1(ValManager.java:220)
    at
org.eclipse.wst.validation.internal.ValManager$ValidatorCache.getValidatorsCached(ValManager.java:1256)
    at
org.eclipse.wst.validation.internal.ValManager.getValidators(ValManager.java:197)
    at
org.eclipse.wst.validation.internal.ValManager.accept(ValManager.java:745)
    at
org.eclipse.wst.validation.internal.ValBuilderJob.startingValidation(ValBuilderJob.java:148)
    at
org.eclipse.wst.validation.internal.ValBuilderJob.runInWorkspace(ValBuilderJob.java:122)
    at
org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:38)
    at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

Looks like the method FilterRule#create(IConfigurationElement rule) has missing
a condition for the target runtime.


Reproducible: Always
Comment 1 Rosendo Martinez CLA 2012-02-08 12:16:45 EST
Created attachment 210745 [details]
Proposed R3_2_5_patches patch
Comment 2 Chuck Bridgham CLA 2012-02-09 08:38:38 EST
approved
Comment 3 Rosendo Martinez CLA 2012-03-16 16:35:05 EDT
Code committed and released to R3_2_5_patches