Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 370977

Summary:	creation of new JavaScriptDevGenerator from WorkingCopyGenerationOperation needs work
Product:	z_Archived	Reporter:	Jeff Douglas <jeffdouglas>
Component:	EDT	Assignee:	Huo Zhen Zhong <huozz>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	chenzhh
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Jeff Douglas

2012-02-08 11:45:09 EST

The method in which the required new instance of JavaScriptDevGenerator in WorkingCopyGenerationOperation isn't quite right, because the static instance of the IGenerator class variables isn't being copied over to this new instance.

Comment 1 Huo Zhen Zhong

2012-02-09 03:16:07 EST

Hi, Jeff
I see that you have modified some code about JavaScriptDevGenerator in WorkingCopyGenerationOperation, do you mean I should not new a JavaScriptDevGenerator but get it from somewhere? If yes, how could I get instance of JavaScriptDevGenerator? Thanks

Comment 2 Jeff Douglas

2012-02-09 07:50:15 EST

No, it seems you do need to do a "new" on it, because you have those override methods. The problem with this "new" technique however, is that it doesn't pick up the variables set by eclipse's startup and the loading of the static version of this class.

Talk with Justin on this. The code in there now will work, but it isn't the best way.

Comment 3 Huo Zhen Zhong

2012-02-10 02:22:06 EST

Hi Jeff
I think the override JavaScriptDevGenerator in only used for VE, it should not be used by others, so I think it is ok to use it that way. Thanks

Comment 4 Jeff Douglas

2012-03-30 12:01:26 EDT

won't be implemented