Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 370961

Summary:	IContributionManagerOverrides not modeled in e4
Product:	[Eclipse Project] Platform	Reporter:	Dean Roberts <dean.t.roberts>
Component:	UI	Assignee:	Platform-UI-Inbox <Platform-UI-Inbox>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	emoffatt, psuzzi, remy.suen
Version:	4.2
Target Milestone:	---
Hardware:	All
OS:	All
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=486406
Whiteboard:	stalebug

Description Dean Roberts

2012-02-08 10:04:17 EST

While putting the CustomizePerspective dialog back into E4 I realized that IContributionManagerOverrides are not being modeled properly in E4.  This resulted in a layout issue that was difficult to track down.

More importantly it makes me worry that we risk drifting away from the E4 philosophy of model driven UI.

The heart of the issue is that a UIElement knows if it is VISIBLE or not.  The Override mechanism works on the SWT layer and not the model layer to hide elements.  A UIElement that is being hidden by an Override will still claim to be Visible if its model is inspected.

As well, when an override hides a UIElement, since its visibility in the model is not changed, no UI event is generated so important rendering code may not be run.

Comment 1 Remy Suen

2012-02-08 13:19:36 EST

This is similar to how the CleanupAddon programmatically collapses model structures. However, this may not actually be what the user wants but we have no way of knowing that something has been preset by the user and should not be modified programmatically.

Comment 2 Patrik Suzzi

2016-01-22 18:34:50 EST

See also bug320478 as the commit contains a workaround for this bug.

You can find the reference to the workaround in 
CoolBarToTrimManager#update() and CoolBarToTrimManager#updateAll()

Comment 3 Eclipse Genie

2020-04-21 05:26:07 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.