Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 370945

Summary:

Examples needed for the component extension

Product:

[Technology] Jubula

Reporter:

Patrick Gutorski <Patrick.Gutorski>

Component:

Core

Assignee:

Patrick Gutorski <Patrick.Gutorski>

Status:

CLOSED WONTFIX

QA Contact:

Oliver Goetz <Oliver.Goetz>

Severity:

enhancement

Priority:

CC:

alexandra.schladebeck, markus.tiede

Version:

unspecified

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
new examples for swing and rcp / swt	none
patch with new extension examples two show how to implement new components and actions	none

Description Patrick Gutorski

2012-02-08 08:33:33 EST

Build Identifier: 

We currently have no example of how to extend an existing component so that it
supports a new action. We should create an example, similar to the example for
the new component extension, that allows people to see how this works.

Reproducible: Didn't try

Comment 1 Patrick Gutorski

2012-02-08 08:37:10 EST

Created attachment 210730 [details]
new examples for swing and rcp / swt

Comment 2 Markus Tiede

2012-02-09 04:58:35 EST

Trying to apply the patch via "git apply patch.file --check" fails due to "fatal: corrupt patch at line 1577". Could you please provide an non-corrupt patch file?

In addition to that could you please add a bit more information on what the patch contains and what is specifically enhanced by applying it e.g. which toolkits, components and actions are affected / introduced?

Comment 3 Patrick Gutorski

2012-02-10 05:33:50 EST

Created attachment 210841 [details]
patch with new extension examples two show how to implement new components and actions

This patch shows with two examples ( one for swing, the second for rcp/swt ) how you can develop new test-actions which are not already implemented in jubula and how to get jubula to support your own custom ui components for teststeps. 

Therefore a example contains a AUT with an unsupported component ( the Slider ), implication classes with new created actions and the ComponentConfiguration.xml for the registration of new components and actions. 

Both examples are similar build to show how the extensions works with different gui toolkits.

Comment 4 Markus Tiede

2012-02-10 10:15:19 EST

Currently I reject the contribution due to the following reasons:
major issues:
 - unknown and unused .directory files in multiple projects
 - outdated copyright header from 2010
 - project "org.eclipse.jubula.examples.extension.rcp.plugin" should be renamed to "org.eclipse.jubula.examples.extension.rcp.aut.plugin" with all its internal names and packages
 - the RC-impl class package is inconsistent
   - duplicate(d) JSliderImplClass
   - swing package structure is inconsistent: "org.eclipse.jubula.rc.swing.swing.implclasses" vs "org.eclipse.jubula.swing.swing.implclasses" for the newly added implementation classes
 - org.eclipse.jubula.examples.extension.swing.aut is no longer Java 1.4 compatible (currently 1.6 is required due to UIManager.getIcon(...) usage)
 - redundant / duplicated *.rc.swt.implclasses.SliderImplClass
 - inconsistent naming of implementation classes: sometimes "MyXYZImplClass" naming scheme is used - sometimes not

minor issues: 
 - missing build / pom integration 

As long as the major issues are not resolved there will be no further analysis / review of the contribution.

Comment 5 Alexandra Schladebeck

2013-12-13 09:10:44 EST

Since there's been no activity on this, and the component extension mechanism has changed since the patch, I'm resolving as wontfix.

Comment 6 Oliver Goetz

2013-12-17 05:11:36 EST

Closed due to comment 5