Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 370915

Summary: [Pattern Post Processor] Pattern output nodes should follow the visitor "pattern"
Product: [Modeling] EMF.EGF Reporter: Matthieu Helleboid <matthieu.helleboid>
Component: CoreAssignee: Thomas Guiu <thomas.guiu>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: benoit.langlois
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
implementation none

Description Matthieu Helleboid CLA 2012-02-08 03:45:38 EST 
Build Identifier: 

A pattern output processor allows to access a tree of node. It would be helpful that this tree implements the visitor design pattern to ease iteration on the subnodes. For example, an accept(...) method on org.eclipse.egf.model.pattern.Node would do it.

Reproducible: Always
Comment 1 Matthieu Helleboid CLA 2012-02-08 03:56:00 EST 
It would also be helpful to have an DefaultPatternOutputProcessor class which implements PatternOutputProcessor and does nothing to avoid the need to implements all methods of PatternOutputProcessor
Comment 2 Benoit Langlois CLA 2012-02-08 04:10:30 EST 
Hi,

Agree with the two points. Matthieu, I think that you can split this bug into two bugs for each request.

Benoît
Comment 3 Matthieu Helleboid CLA 2012-02-08 04:21:58 EST 
Hi Benoit, 

you're right, and it came to mind as soon as I hitted the submit button :-)
done : https://bugs.eclipse.org/bugs/show_bug.cgi?id=370920

Thx
Comment 4 Matthieu Helleboid CLA 2012-02-08 06:15:25 EST 
Created attachment 210720 [details]
implementation
Comment 5 Thomas Guiu CLA 2012-02-09 04:21:02 EST 
The visitor class has been added.
Comment 6 Benoit Langlois CLA 2012-05-28 10:42:37 EDT 
OK