Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 370799

Summary: NPE on "Compare with Version in Ancestor"
Product: [Technology] EGit Reporter: Alexander Weickmann <alexander.weickmann>
Component: UIAssignee: Project Inbox <egit.ui-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3    
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Alexander Weickmann CLA 2012-02-07 04:44:33 EST
Build Identifier:  20110916-0149

Here's the stack trace:

java.lang.NullPointerException
	at org.eclipse.jgit.util.RawParseUtils.author(RawParseUtils.java:560)
	at org.eclipse.jgit.revwalk.RevCommit.getAuthorIdent(RevCommit.java:338)
	at org.eclipse.egit.core.internal.storage.CommitFileRevision.<init>(CommitFileRevision.java:59)
	at org.eclipse.egit.core.internal.storage.GitFileRevision.inCommit(GitFileRevision.java:54)
	at org.eclipse.egit.ui.internal.CompareUtils.getFileRevision(CompareUtils.java:149)
	at org.eclipse.egit.ui.internal.CompareUtils.getFileRevisionTypedElement(CompareUtils.java:109)
	at org.eclipse.egit.ui.internal.history.CommitFileDiffViewer.showTwoWayFileDiff(CommitFileDiffViewer.java:378)
	at org.eclipse.egit.ui.internal.history.CommitFileDiffViewer$6.run(CommitFileDiffViewer.java:225)
	at org.eclipse.jface.action.Action.runWithEvent(Action.java:498)
	at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
	at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
	at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4165)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3754)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494)
	at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:123)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1386)

I've chosen severity major, as this is a functionality I need very often.

Reproducible: Sometimes

Steps to Reproduce:
1. Pull from repository
2. Open all commits, so you have them as open editors
3. Browse through changes, using "Compare with Version in Ancestor" on the individual files

Sometimes, the compare editor does not open up and the above exception can be found in the error log. I don't know what exactly are the circumstances that cause the exception.
Comment 1 Kevin Sawicki CLA 2012-02-07 11:05:20 EST
What version of EGit are you using?
Comment 2 Alexander Weickmann CLA 2012-02-07 12:11:42 EST
1.1.0.201109151100-r
Comment 3 Kevin Sawicki CLA 2012-02-07 16:17:29 EST
Would you be able to upgrade to 1.2 from here http://download.eclipse.org/egit/updates and see if the problem persists?
Comment 4 Alexander Weickmann CLA 2012-02-16 12:30:19 EST
I've updated to 1.2 right after your comment and did not again encounter the problem since then. Therefore I would suggest to close this issue. Should I receive the NPE again, I can still add a comment and you can reopen the issue.
Comment 5 Kevin Sawicki CLA 2012-02-23 18:38:15 EST
Closing as fixed