| Summary: | [Compatibility] With CDT, instruction stepping mode does not work | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Marc-André Laperle <malaperle> | ||||
| Component: | UI | Assignee: | Remy Suen <remy.suen> | ||||
| Status: | VERIFIED FIXED | QA Contact: | Remy Suen <remy.suen> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | remy.suen | ||||
| Version: | 4.2 | ||||||
| Target Milestone: | 4.2 M6 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 331444 | ||||||
| Attachments: |
|
||||||
|
Description
Marc-André Laperle
Created attachment 210608 [details]
Instruction stepping mode button
The action doesn't seem to be checked so the code doesn't even up showing the view. In 3.x we don't go through the ActionDelegateHandlerProxy so we don't get another call to selectionChanged(*) which prevents the action from thinking it is unchecked. ToggleInstructionStepModeActionDelegate.run(IAction) line: 97 ToggleInstructionStepModeActionDelegate.runWithEvent(IAction, Event) line: 117 ViewPluginAction(PluginAction).runWithEvent(Event) line: 241 PluginActionContributionItem(ActionContributionItem).handleWidgetSelection(Event, boolean) line: 584 ActionContributionItem.access$2(ActionContributionItem, Event, boolean) line: 501 ActionContributionItem$6.handleEvent(Event) line: 452 EventTable.sendEvent(Event) line: 84 ToolItem(Widget).sendEvent(Event) line: 1053 Fix pushed to master. http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6fd0c2f0c6ab2bc5e5801888a84f88066c2e1164 Verified with I20120312-1730 on Windows 7. Thank you for the bug report! |