Bugzilla – Full Text Bug Listing
| Summary: | No icons on the Debug view Layout action | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Michael Rennie <Michael_Rennie> | ||||||||||||||
| Component: | Debug | Assignee: | Pawel Piech <pawel.1.piech> | ||||||||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||||||||
| Severity: | minor | ||||||||||||||||
| Priority: | P3 | CC: | pawel.1.piech | ||||||||||||||
| Version: | 3.8 | Keywords: | polish | ||||||||||||||
| Target Milestone: | 3.8 M6 | ||||||||||||||||
| Hardware: | PC | ||||||||||||||||
| OS: | Windows 7 | ||||||||||||||||
| Whiteboard: | |||||||||||||||||
| Attachments: |
|
||||||||||||||||
Created attachment 210602 [details]
debug view with no icons
The problem is that we do not set the image descriptor in DebugViewModeAction Created attachment 211426 [details]
Tree mode icon
Created attachment 211427 [details]
Breadcrumb mode icon.
Created attachment 211428 [details]
Auto mode icon.
Given my limited artistic abilities. Here are the icons I hacked up for the debug view layout menu. Mike is this what you had in mind?
Created attachment 211440 [details]
screen shot
looks good to me.
Since I have the changes in my workspace do you want me to push it for you?
Sure, I had only drawn the icons so far, but if you hooked them up already then go ahead :-) (In reply to comment #6) > Created attachment 211440 [details] > screen shot Oh I see, you just re-used the detail pane icons instead of the ones I attached. That's fine by me too. pushed the changes to: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=5c262bb68d00bf5afe1fa59c20097a48fec550a2 Verified in: Version: 4.2.0 Build id: I20120313-0610 |
Created attachment 210601 [details] bp view with action icons Version: 4.2.0 Build id: I20120126-1300 Unlike the rest of the debug views, the Debug View > Layout actions do not have the associated icons on the actions. See the attached screen shots