Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 370637

Summary:	When using the AST, leaving a while statement is not notified
Product:	[Tools] CDT	Reporter:	Gil Barash <scobido1984>
Component:	cdt-parser	Assignee:	Markus Schorn <mschorn.eclipse>
Status:	RESOLVED FIXED	QA Contact:	Markus Schorn <mschorn.eclipse>
Severity:	normal
Priority:	P3	CC:	cdtdoug, scobido1984, yevshif
Version:	8.0
Target Milestone:	8.1.0
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Gil Barash

2012-02-04 10:36:37 EST

Build Identifier: Ecliupse 3.7.1 - CDT 8.0.0.201106081058

I built a AST visitor, enabling only "shouldVisitStatements".
The "public int visit(IASTStatement statement)" is called for "while statements", but the "public int leave(IASTStatement statement)" is not called.

This happens only in C++ code (not C).

I believe the problem is caused by a typo in the "CPPASTWhileStatement" class, in the function "accept(ASTVisitor action)" (line 117, in my source version). It states "if (action.shouldVisitExpressions)" instead of "if (action.shouldVisitStatements)".




Reproducible: Always

Comment 1 Markus Schorn

2012-04-04 02:30:28 EDT

Thanks!

Comment 2 CDT Genie

2013-02-27 11:38:48 EST

*** cdt git genie on behalf of Markus Schorn ***

    Bug 370637: Visiting while statements.

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=105de6f15d2ff84d16616098e43ed76ba93d1ef5