Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 370633

Summary:

hide hash ids from Task List

Product:

z_Archived

Reporter:

Steffen Pingel <steffen.pingel>

Component:

Mylyn

Assignee:

Steffen Pingel <steffen.pingel>

Status:

RESOLVED FIXED

QA Contact:

Severity:

trivial

Priority:

CC:

sascha.scholz

Version:

unspecified

Target Milestone:

0.9

Hardware:

OS:

Linux

Whiteboard:

Bug Depends on:

Bug Blocks:

369290

Attachments:

Description	Flags
screenshot	none
mylyn/context/zip	none

Description Steffen Pingel

2012-02-04 08:37:56 EST

I would like to reconsider the changes made for bug 334806. As discussed during the Gerrit connector UI review the change ids add noise to the Task List presentation and are not helpful to identify reviews. I can see the use for filtering but I would like to remove them from the presentation or show them as decoration.

Comment 1 Steffen Pingel

2012-02-04 08:38:33 EST

Sascha, what are your thoughts on that? How important is it to you to have the hash codes in the task list?

Comment 2 Sascha Scholz

2012-02-05 11:19:19 EST

I'm open to having the behavor changed. The only use-case I see is filtering although I find the IDs odd and hard to remember (but we can't get blamed for that...). The only question I still have is what the difference between Gerrit Change IDs and Bugzilla or Jira issue IDs is. They are always shown in the task list.

Comment 3 Steffen Pingel

2012-02-11 09:01:02 EST

Created attachment 210884 [details]
screenshot

Comment 4 Steffen Pingel

2012-02-11 09:08:37 EST

JIRA and Bugzilla use a decimal value or a combination of a project name and decimal value.  My feeling that because hexadecimal values are a not commonly used they are harder to read and recognize than decimal values and hence it looks a bit odd in the Task List. 

The other nice property of Bugilla and JIRA IDs is the natural ordering. You can easily see which tasks were created more recently and the task list uses that for sorting. I found it difficult to locate reviews in the Task List particularly since we are missing priority.

I have committed 8ab8013357c7cc9517ef3dc82219358b1dd371e8 which reintroduces the decimal ids and keys and appends the hash id to the summary. Let's run with that for a bit. If it gets in the way we can always change it again.

Comment 5 Steffen Pingel

2012-02-11 09:08:40 EST

Created attachment 210885 [details]
mylyn/context/zip

Comment 6 Sascha Scholz

2012-02-11 14:33:03 EST

That looks great! Another advantage of the decimal IDs is that they are consistent with the branch names that are suggested by the Egit 'Fetch change from Gerrit' wizard.