Bugzilla – Full Text Bug Listing
| Summary: | Support dynamic tracing for e4 workbench | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Curtis Windatt <curtis.windatt.public> | ||||||
| Component: | UI | Assignee: | Platform UI Triaged <platform-ui-triaged> | ||||||
| Status: | CLOSED WONTFIX | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | daniel_megert, Lars.Vogel, Michael_Rennie, pwebster | ||||||
| Version: | 4.2 | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | stalebug | ||||||||
| Attachments: |
|
||||||||
|
Description
Curtis Windatt
Created attachment 210531 [details]
Fix
I got an internal exception while trying to push to GitHub using eGit so I'm attaching a patch. Debugging eGit can wait until next week.
We can't have a dependency on org.eclipse.ui as part of the e4 bundles, and org.eclipse.ui.trace depends on o.e.ui. If it doesn't need any code, you can just include the extension right? PW (In reply to comment #2) > If it doesn't need any code, you can just include the extension right? > > PW Yes, that is fine. The extension could also be moved to another plug-in that can have direct dependencies on ui as well as e4. Fix without dependency can be found here: https://github.com/CWindatt/eclipse.platform.ui/commit/cdd3858d8ba7efa200adf94c19a113f63bd55ae4 No rush to putting this in as the tracing bundle may get changed in the near future for better auto-starting (bug 369916) Better fix: https://github.com/CWindatt/eclipse.platform.ui/commit/22fb85d9bed6bf29a203b4e0a3c8a6bd73138374 Initializes debug trace using a listener to ensure the tracing ui bundle gets started. I commented out a number of debug options that are not used in the bundles and cleaned up the constants. Fix is also available at Michael's GitHub fork: https://github.com/mrennie/eclipse.platform.ui/commit/22fb85d9bed6bf29a203b4e0a3c8a6bd73138374 (In reply to Curtis Windatt from comment #5) > Better fix: > https://github.com/CWindatt/eclipse.platform.ui/commit/ > 22fb85d9bed6bf29a203b4e0a3c8a6bd73138374 Could you convert that into a Gerrit review? Created attachment 244989 [details]
Github pullrequest as a patch
I added my github fork as a remote and created this patch. I haven't tried applying it to master, which is 1000 commits ahead of the pull request, so good luck :)
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |