Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 370600

Summary:	OpenResourceDialog.js module dependencies not resolving
Product:	[ECD] Orion	Reporter:	John Arthorne <john.arthorne>
Component:	Client	Assignee:	Project Inbox <orion.client-inbox>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.4
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description John Arthorne

2012-02-03 14:27:31 EST

In bug 369892, new dependencies on orion modules were added to OpenResourceDialog.js. This worked correctly on a deployed self-hosting environment, but failed when run through our build. My only guess is that perhaps there is a path problem because this widget is in a different directory from other Orion scripts with module imports.

Comment 1 John Arthorne

2012-02-06 13:38:30 EST

I have been debugging the built code, and I'm starting to think this is a
require.js bug. 

1) I put a breakpoint inside the module definition for "orion/globalCommands",
which is referencing "orion/searchRenderer". 
2) I put a breakpoint inside the definition of the "orion/searchRenderer"

1) is getting hit before 2). So, the code that requires the renderer gets
executed before the search renderer module even gets defined. Of course the
required module is passed in as null and the execution fails. We have fairly
deeply nested modules here and I wonder if we are hitting:

https://github.com/jrburke/requirejs/issues/173

This is supposedly fixed in Require.js version 1.0.5. I think to get us going
again I'll have to inline the rendering code again, and revisit after we moved
up to require.js 1.0.5.

Comment 2 John Arthorne

2015-05-05 14:40:23 EDT

Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:

https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html