Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 370586

Summary:	new highlight.js caused missing functionality
Product:	[ECD] Orion	Reporter:	Felipe Heidrich <eclipse.felipe>
Component:	Editor	Assignee:	Mark Macdonald <mamacdon>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P2	CC:	mamacdon, Silenio_Quarti
Version:	0.4
Target Milestone:	0.4 RC1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Felipe Heidrich

2012-02-03 12:25:54 EST

I noticed that some of the code that was in setup.js got moved to a better place.


But in the process some features got lost:
apparently mTextStylerOptions is not being installed in the editor
as consequence the editor preferences pages is not working
also noticed that mTextStylerOptions was not removed from setup.js require list as it should have.


other feature that was lost is folding (and while you are at, please make folding a preference ;-).


Not saying that this code should go in highlight.js (as it was sort of hack in setup.js anyway) but this needs to be fixed.

Thank you

Comment 1 Mark Macdonald

2012-02-03 13:16:21 EST

(In reply to comment #0)
> I noticed that some of the code that was in setup.js got moved to a better
> place.
> 
> 
> But in the process some features got lost:
> apparently mTextStylerOptions is not being installed in the editor
> as consequence the editor preferences pages is not working
> also noticed that mTextStylerOptions was not removed from setup.js require list
> as it should have.
> other feature that was lost is folding 

Good catch, thanks! There was a bunch of styler-initialization code in setup that was a bit tangled, and I lost TextStylerOptions and folding while I was rearranging it. Fixed in http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=c5112a2bc6b45d70bf627c76b50ddfcdbf58d31a

> (and while you are at, please make folding a preference ;-).

Ok, I'll look at this in a follow-up commit.

Maybe we should extract some common API from stylers so that something like TextStylerOptions can configure them all?

Comment 2 Felipe Heidrich

2012-02-03 17:03:19 EST

> Maybe we should extract some common API from stylers so that something like
> TextStylerOptions can configure them all?

I'm already added getClassNameForToken() to TextStyler because of TextStylerOptions. Lets talk Monday.

Comment 3 Mark Macdonald

2012-02-08 10:46:49 EST

Opened bug 370965 for the folding pref.

Closing this one, see commit comment 1.