Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 370539

Summary:	GitCloneTest.testCloneMissingUserInfo() failed
Product:	[ECD] Orion	Reporter:	Tomasz Zarna <tomasz.zarna>
Component:	Git	Assignee:	Malgorzata Janczarska <malgorzata.tomczyk>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	malgorzata.tomczyk
Version:	0.4
Target Milestone:	0.4 RC1
Hardware:	PC
OS:	Windows XP
URL:	http://download.eclipse.org/orion/drops/I201202052230/org.eclipse.orion.server.tests.AllServerTests.html
Whiteboard:

Description Tomasz Zarna

2012-02-03 06:00:29 EST

GitCloneTest.testCloneMissingUserInfo() failed again.

expected:<200> but was:<400> 

java.lang.AssertionError: expected:<200> but was:<400>
at org.eclipse.orion.server.tests.servlets.git.GitCloneTest.testCloneMissingUserInfo(GitCloneTest.java:248)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:501)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:259)
at org.eclipse.test.CoreTestApplication.runTests(CoreTestApplication.java:36)
at org.eclipse.test.CoreTestApplication.run(CoreTestApplication.java:32)
at org.eclipse.equinox.internal.app.EclipseAppContainer.callMethodWithException(EclipseAppContainer.java:587)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:198)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:352)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:624)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:579)
at org.eclipse.equinox.launcher.Main.run(Main.java:1433)
at org.eclipse.equinox.launcher.Main.main(Main.java:1409)
at org.eclipse.core.launcher.Main.main(Main.java:34)

Comment 1 Tomasz Zarna

2012-02-03 10:51:58 EST

It's most probably caused by a "missing host exception" returned from the server as 400. Modified the test a bit to double check it -- c4f02acd7ca1c718b297d340a5ca912b14bb069f

Comment 2 Malgorzata Janczarska

2012-02-06 04:50:11 EST

*** Bug 370687 has been marked as a duplicate of this bug. ***

Comment 3 Tomasz Zarna

2012-02-06 04:51:36 EST

From the failure in I201202052230 [1] we can get this kind of additional info:
{
"Severity":"Error",
"Message":"ssh://git.eclipse.org/gitroot/platform/eclipse.platform.news.git: username must not be null.",
"HttpCode":400,
"Code":0,
"DetailedMessage":"ssh://git.eclipse.org/gitroot/platform/eclipse.platform.news.git: username must not be null.",
"JsonData":{
	"Scheme":"ssh",
	"Url":"ssh://git.eclipse.org/gitroot/platform/eclipse.platform.news.git",
	"Host":"git.eclipse.org",
	"HumanishName":"eclipse.platform.news"
	}
}

Rest of the stacktrace is identical to the one from comment 0.

[1] http://download.eclipse.org/orion/drops/I201202052230/org.eclipse.orion.server.tests.AllServerTests.html

Comment 4 Malgorzata Janczarska

2012-02-06 04:54:36 EST

It seems that we expected this error in test. The only problem here is that the test was expected to end up as a task and it finished much faster. I had to miss this test when I migrated clone operation to TaskJob that does not necessary end up as a task, or maybe this test is newer.
I can take it from here, Tomek, if you want.

Comment 5 Tomasz Zarna

2012-02-06 04:56:32 EST

(In reply to comment #4)
> I had to miss this test when I migrated clone operation to TaskJob that does not necessary end
> up as a task, or maybe this test is newer.

You didn't miss it, it's a new test added in bug 369282.

> I can take it from here, Tomek, if you want.

Be my guest. Thx!

Comment 6 Malgorzata Janczarska

2012-02-06 06:27:53 EST

Done. I added getResult helper method to GitTest that returns what should be in task Result no meter if it ended in task or returned directly.