Bugzilla – Full Text Bug Listing
| Summary: | Creating a product for a plugin -> Extension tab is still empty until editor is closed an re-opened | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Lars Vogel <Lars.Vogel> | ||||||||||
| Component: | UI | Assignee: | Dani Megert <daniel_megert> | ||||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||||
| Severity: | major | ||||||||||||
| Priority: | P3 | CC: | curtis.windatt.public, daniel.esser, daniel_megert, ines.lelle, Lars.Vogel, michael.schiepe, nobody, Peter_Weihrauch, ralf.hockner, sven.klemm | ||||||||||
| Version: | 4.2 | ||||||||||||
| Target Milestone: | 3.8 M7 | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Whiteboard: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Lars Vogel
I've ended up in cases where the manifest editor is open without any extension tabs at all. Then once the plugin.xml is created, double clicking on it will only open the existing manifest editor with no extension tabs. Definitely annoying. @Curtis, thanks for the confirmation of this behavior. Especially as this way is not more likely to happen as its the standard way to convert a plug-in into an Eclipse 4 application. This happens every time you create an Eclipse 4 application from scratch. I think the priority of this bug should be increased as this might affect the Eclipse 4 adapter. To reproduce this please follow the following description:http://www.vogella.de/articles/Eclipse4RCP/article.html#plugin_creatinge4 This setup only takes a few minutes. I think the problem is if the plugin.xml does not contain extension and the product creates the extension the plugin.xml editor does not see this change. Lars, is this a regression compared to 4.1? Does it work in 3.7.2? Hi Dani, no, in Eclipse 3.7 its the same behavior. But you rarely see this issue, as the process of creating applications is different, you usually don't have an empty plugin.xml before creating the "org.eclipse.core.runtime.products" extension point via the product configuration file. You might want to lower the priority if my classification was incorrect. I think that one will affect almost everyone how creates an Eclipse 4 RCP app but I'm not really familiar with the bug classification approach in Bugzilla. Best regards, Lars (In reply to comment #5) Lars, steps/examples from comment 0 and comment 3 start at different locations. Could you attach a starting point/project and then the steps to reproduce the problem? That would simplify it on our side. Created attachment 213578 [details]
Project for bugreport
Sorry, attached project does NOT work. Here is a simple way to reproduce it: 1.) Create new (simple) plug-in (no activator, not an RCP, no contribution to the UI) 2.) Right mouse click on project -> Create product configuration with basic settings. File name "todo.product" 3.) In the "Product Definition" on the "Overview" tab press new. Enter "todo" as name, Product ID: "product" and select "org.eclipse.e4.ui.workbench.swt.E4Application" as application. Press Finish and open the "MANIFEST.MF", tab "Extensions". It is empty. Open "plugin.xml" in a text editor and validate that the file contains entries. (In reply to comment #8) > Sorry, attached project does NOT work. > > Here is a simple way to reproduce it: > > 1.) Create new (simple) plug-in (no activator, not an RCP, no contribution to > the UI) > 2.) Right mouse click on project -> Create product configuration with basic > settings. File name "todo.product" > 3.) In the "Product Definition" on the "Overview" tab press new. Enter "todo" > as name, Product ID: "product" and select > "org.eclipse.e4.ui.workbench.swt.E4Application" as application. > > Press Finish and open the "MANIFEST.MF", tab "Extensions". It is empty. Open > "plugin.xml" in a text editor and validate that the file contains entries. I followed your steps using 3.8 M6 and latest 4.2 build and to me it seems to work (or we're talking about a different bug). Even without saving after step 3, I see the extensions. See attached picture. Did I not get the point? Created attachment 213582 [details]
Picture
Thanks Dani for testing. Strange, I can easily reproduce that with Eclipse 4.2M6. I have created a small step to step description (attached ad .odf and pdf). I never pressed Ctrl+S in the whole process. Created attachment 213583 [details]
TestScript
Created attachment 213584 [details]
TestScript as PDF in case odt does not work for someone
OK, I can reproduce now. The key is that the manifest editor must already be open, otherwise all works fine. Fixed in master: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=2bca6068ccfb754df68ab8dde8a05ee9657bc79a Awesome. Thanks Dani! Testing on I20120503-1800 Ubuntu, the plugin.xml tab is added to the editor correctly, but the extensions and extension points tabs are not. Closing and reopening the editor solves the issue. (In reply to comment #17) > Testing on I20120503-1800 Ubuntu, the plugin.xml tab is added to the editor > correctly, but the extensions and extension points tabs are not. Closing and > reopening the editor solves the issue. I'm not able to open the Manifest editor without getting the 'Extensions' and 'Extension Points' tab. Even if I open a completely empty 'MANIFEST.MF'. I think the original bug, namely the missing 'plugin.xml' tab and the entry in the 'Extensions' tab, is fixed. Please file a new bug with exact steps to reproduce if it doesn't work for you. I'm also unable to reproduce this issue any more on Ubuntu 11.10. I agree with Dani, "my" bug seem to be fixed. FYI - Also my currently running Eclipse 4 with M7 training (12 people), I have not seen this issue. :-) Thanks for the feedback Lars! Thanks for the fix, Dani! (In reply to comment #18) > (In reply to comment #17) > > Testing on I20120503-1800 Ubuntu, the plugin.xml tab is added to the editor > > correctly, but the extensions and extension points tabs are not. Closing and > > reopening the editor solves the issue. > > I'm not able to open the Manifest editor without getting the 'Extensions' and > 'Extension Points' tab. Even if I open a completely empty 'MANIFEST.MF'. I > think the original bug, namely the missing 'plugin.xml' tab and the entry in > the 'Extensions' tab, is fixed. > > Please file a new bug with exact steps to reproduce if it doesn't work for you. The reason why my behaviour is different is that I am starting with an OSGi bundle project, not a plug-in project (select OSGi Framework: Equinox in the new wizard). This turns off the project property 'always show extensions/extension points tabs'. When the product is created, the plugin.xml tab is added to the editor, but not the extensions tabs. While I find the plugin.xml tab showing up a little odd, I don't think it warrants a new bug as a product developer shouldn't be creating a non-plugin project. I agree the original bug is fixed. |