Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 370457

Summary:	sdk.plus both includes examples and export.batik
Product:	[Modeling] Graphiti	Reporter:	Christian Georgi <christian.georgi>
Component:	Core	Assignee:	Michael Wenz <michael.wenz>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	matthias.gorning, michael.wenz
Version:	0.8.0	Flags:	michael.wenz: indigo+ michael.wenz: juno+
Target Milestone:	0.8.0
Hardware:	All
OS:	All
Whiteboard:	Juno M6 Theme_bugs Indigo SR2

Description Christian Georgi

2012-02-02 10:47:29 EST

Build Identifier: 3.7

With existing features of Graphiti there is no clean way to just get export.batik bundle without also getting Graphiti's example feature.  Both of them are included in sdk.plus feature.

Reproducible: Always

Comment 1 Michael Wenz

2012-02-02 11:42:52 EST

A first idea would be to add an org.eclipse.graphiti.exporters.feature feature (name to be discussed) that contains the export.batik plugin. The exporters feature would then be included in the SDK+ feature instead of directly including the export.batik plugin.
For SDK+ users nothing would change, but products would not be forced to use the SDK+ feature when they need the export.batik stuff; they could simply use the features org.eclipse.graphiti.feature and org.eclipse.graphiti.exporters.feature.

This would be the new structure:
org.eclipse.graphiti.sdk.plus.feature
  org.eclipse.graphiti.sdk.feature
    org.eclipse.graphiti.feature
      <All Graphiti runtime plugins>
    org.eclipse.graphiti.feature.examples
      <All Graphiti example plugins>
    org.eclipse.graphiti.source.feature
      <All Graphiti Runtime source plugins>
    org.eclipse.graphiti.feature.examples.source
      <All Graphiti Example source plugins>
  org.eclipse.graphiti.exporters.feature           <--- new
    Plugin org.eclipse.graphiti.export.batik

Comment 2 Christian Georgi

2012-02-03 02:53:08 EST

Sounds good. +1

Comment 3 Michael Wenz

2012-02-03 07:01:37 EST

I have added an additional feature that wraps the plugin org.eclipse.graphiti.export.batik (the name is org.eclipse.graphiti.export.feature) and added it as part of the SDK+ feature.
Change is checked-in for 0.8.2 (Indigo SR2 RC3) and pushed to Eclipse:
commit 0a0d5679728fae21f35bb9aa789fb7a6565574b2
Author: mwenz <michael.wenz@sap.com> 2012-02-03 10:31:16
Committer: mwenz <michael.wenz@sap.com> 2012-02-03 10:31:16
Parent: 5a252edef93e5b6a3122bdb1c9292edca7540841 (provide bundle name and vendor * Bundle-Localization added to manifest file)
Child: 01a5877c3caed834b98810f5bc1b1ec254c75f65 (Bug 370457: Added new feature to site)
Branches: origin/b0_8_x, b0_8_x

Comment 4 Michael Wenz

2012-02-03 07:04:54 EST

A first build for 0.8.2 SR2 that contains the change is available:
Update site: http://download.eclipse.org/graphiti/updates/milestones/S-0.8.2SR2RC3-201202031122
Archive: http://download.eclipse.org/graphiti/archives/milestones/org.eclipse.graphiti.site_0.8.2SR2RC3.201202031122.zip

Comment 5 Christian Georgi

2012-02-03 07:32:16 EST

Thanks, Michael.  Can you also make sure the new feature is aggregated into Indigo updatesite?

Comment 6 Michael Wenz

2012-02-03 07:36:07 EST

(In reply to comment #5)
> Thanks, Michael.  Can you also make sure the new feature is aggregated into
> Indigo updatesite?

This milestone build will be picked up by the Indigo aggregator and will be part of the Indigo SR2 update site. Nothing more to do for that... :-)

Comment 7 Michael Wenz

2012-02-03 07:36:44 EST

Change has also been ported to the master branch for Graphiti 0.9.0 (Juno M6)

Comment 8 Christian Georgi

2012-02-03 07:58:28 EST

(In reply to comment #6)
> (In reply to comment #5)
> > Thanks, Michael.  Can you also make sure the new feature is aggregated into
> > Indigo updatesite?
> 
> This milestone build will be picked up by the Indigo aggregator and will be part
> of the Indigo SR2 update site. Nothing more to do for that... :-)
Ok, I thought that new features had to be explicitly mentioned in the B3 aggregator model.

Comment 9 Michael Wenz

2012-02-03 08:24:53 EST

(In reply to comment #8)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > Thanks, Michael.  Can you also make sure the new feature is aggregated into
> > > Indigo updatesite?
> > 
> > This milestone build will be picked up by the Indigo aggregator and will be part
> > of the Indigo SR2 update site. Nothing more to do for that... :-)
> Ok, I thought that new features had to be explicitly mentioned in the B3
> aggregator model.
Ah, that's what you meant. That's true and I forgot to mention that I already did that with the availability of the Indigo update site.
But it's still open for Juno, since there's no M6 milestone available yet. (That's why the bug is still open.)

Comment 10 Michael Wenz

2012-02-06 09:19:22 EST

I have added the new export feature to the Juno aggregator now as well

Comment 11 Michael Wenz

2012-04-11 10:56:22 EDT

Bookkeeping: Set target release: 0.8.2

Comment 12 Michael Wenz

2012-06-29 04:21:42 EDT

Part of Graphiti 0.9.0 (Eclipse Juno)