Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 370430

Summary:	[KeyBindings] Rename "Workbench" context and hide if not supported
Product:	[Eclipse Project] Platform	Reporter:	Paul Webster <pwebster>
Component:	UI	Assignee:	Platform UI Triaged <platform-ui-triaged>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P5	CC:	daniel_megert, markus.kell.r, prakash, pwebster, remy.suen
Version:	4.2
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:	stalebug
Bug Depends on:	333417
Bug Blocks:

Description Paul Webster

2012-02-02 08:06:06 EST

See attachment 186990 [details] 
See bug 333417 comment 5

+++ This bug was initially created as a clone of Bug #333417 +++

Follow-up to bug 74073

(In reply to bug 74073 comment #29 and following)
> Do we really need the new context? It looks weird in the 'Keys' pref page:
> When: 'Workbench'.
> Also, it doesn't seem to work, e.g. if I assign commands using that context
> they won't be enabled - hence the context is very misleading. I think we should
> be very careful in defining a new context and avoid it if possible.

(In reply to bug 74073 comment #33)
> Well, I would interpret 'Workbench' context as the context enabled when a
> workbench is active and not the other way around and I would also expect that
> if I bind an existing command to it (e.g. Save) it will work when a workbench
> window is active.

I think the best solution would be to give the context a correct name (e.g. "No Windows" or "No Windows Shown") and a better ID that corresponds to the new name.

To avoid the confusing UI in applications that don't support the windowless mode, the Keys preference page should hide the unsupported context if IWorkbenchConfigurer#getExitOnLastWindowClose() is false.

Comment 1 Eclipse Genie

2020-04-13 17:49:41 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.